Commit graph

24 commits

Author SHA1 Message Date
Marcin Kuzminski
ff79205313 global-permissions: ported controller to pyramid view.
- fixed some other tests cases to rely on test routing
2017-07-20 15:04:36 +02:00
Marcin Kuzminski
b2714a3c1d changelog: ported to pyramid views. 2017-07-18 00:07:43 +02:00
Marcin Lulek
e919908333 security: make sure the admin of repo can only delete comments which are from the same repo.
- fixes IDOR issue
- protects against other people comment deletion by repo admins.
2017-06-19 21:15:37 +02:00
Marcin Kuzminski
926a79e98e audit-logs: implemented pull request and comment events. 2017-06-17 15:22:50 +02:00
Marcin Kuzminski
5915f38fcf pull-request-api: updated logic of closing a PR via API call.
- consistent logic via web and API
- updated events
- updated proper close checks.
2017-06-13 00:14:21 +02:00
Marcin Kuzminski
47f9f32ad9 events: expose permalink urls for different set of object.
- permalink url should provide a non-changeable url that can be used in
external sources with guarantee of beeing always valid.
2017-06-08 16:11:33 +02:00
Marcin Kuzminski
53b4ac98f8 repo-summary: re-implemented summary view as pyramid.
- changed exception handler, to now work in pure pyramid mode
- changed missing requirements logic on repo based views that require vcs-connection
2017-06-07 13:23:21 +02:00
Marcin Kuzminski
bd1e865c9c pull-request: extended default reviewers functionality.
- added mandatory reviewers JS logic Fixes: #4219
- added option to forbid author to be a reviewer via JS/Frontend checks. Fixes #5190
- added option to forbid adding new reviewers except those defined. Fixes #5208
2017-05-29 20:10:17 +02:00
Marcin Kuzminski
7216dd64ff audit-logs: introduced new view to replace admin journal.
- audit logs will represent the all important actions made inside the system
- raw view visible for super-admins
2017-05-19 10:33:10 +02:00
Marcin Kuzminski
726bc5aba8 hooks: deprecate old action_logger 2017-05-17 16:42:00 +02:00
Marcin Kuzminski
664cbc6f52 audit-logs: add push/pull actions to audit logs. 2017-05-09 15:19:04 +02:00
Marcin Kuzminski
e5360e80e4 pull-reqests: workflow, change who can close a PR, it's only super-admin
owner or person who can merge.

- before it was every reviewer can close. Which really doesn't make sense.
2017-04-24 10:25:16 +02:00
Marcin Kuzminski
89dc191e0d pull-requests: add explicit CLOSE pr action instead of closed status from selector.
- This is much better UX
- we set status based on calculated review
- fixes #5215
2017-02-15 11:48:54 +01:00
Marcin Kuzminski
30637758d6 pull-requests: unified merge checks.
- same logic is now used for API, pre-conditions on show, and checks on actual merge
- added checks into API because it was not validated
2017-01-18 14:56:20 +01:00
Marcin Kuzminski
fcc027c282 license: updated copyright year to 2017 2017-01-02 09:30:39 +01:00
Marcin Kuzminski
510f700051 pull-requests: moved the delete logic into the show view.
- delete from pr view is more intuitive
- there was several support queries about beeing confused how to delete a pr
2016-10-30 20:58:11 +01:00
Martin Bornhold
6ea00dcc6d tests: Add test to check PR page when target reference is missing.
The pr page should display the desired error message to the user.
2016-10-27 11:44:45 +02:00
Martin Bornhold
9bc3e546a4 tests: Fix test by using flash message text from model. 2016-10-27 11:43:57 +02:00
Martin Bornhold
c576b1e5e2 tests: Add test to check the link to the shadow repo of a PR. 2016-10-23 14:39:53 +02:00
Daniel Dourvaris
25f2c0b8b2 tests: add test for pull request with multiple commits and reflect
peppercorn usage in other pull request tests
2016-10-12 08:27:31 +03:00
Daniel Dourvaris
b3e97c1715 reviewers: store reviewer reasons to database, fixes #4238 2016-09-27 02:34:15 +03:00
lisaq
ea4cb9d4ae tests: fixes #4168 removing git xfails in pr and vcs commit tests 2016-08-17 17:58:11 +02:00
Johannes Bornhold
9f6ff5bd02 pytest: Use hardcoded login URLs in tests.
- It's not so easy to use pyramids URL generation methods from within the tests.
- Therfore we hardcode the URLs.
2016-05-25 16:46:10 +02:00
Marcin Kuzminski
9a0d8c0b77 project: added all source files and assets 2016-05-24 15:56:53 +02:00