engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2251 commits 1 branch 0 tags 110 MiB
Commit graph

66 commits

Author SHA1 Message Date
Marcin Kuzminski
3839c4720e forms: unified usage of h.secure_form. Make sure we ALWAYS pass in 
request, and removed redundant 'POST' type.
 2017-09-20 16:43:08 +02:00
Marcin Kuzminski
57031945a3 pull-requests: use merge info to show how Pull requests will be merged. 
- rebase or merge commit is shown as merge strategy.
- close/delete branch are shown if that option is selected.
 2017-08-23 13:48:10 +02:00
Marcin Kuzminski
c7704859cf pull-requests: in case of an error redirect to the same url as source. 
- will keep the bookmark/branch info, and help re-select proper revisions.
 2017-08-23 12:31:38 +02:00
Marcin Lulek
c522025775 pull-requests: add copy helpers into pull requests clone/pull url inputs. 2017-07-27 12:59:20 +02:00
Marcin Kuzminski
b203d5f208 pull-requests: migrated code from pylons to pyramid 2017-07-27 11:30:55 +02:00
Marcin Kuzminski
93c5a7f9c5 compare: migrated code from pylons to pyramid views. 2017-07-26 13:28:45 +02:00
Marcin Kuzminski
8efc4d92c5 repo-commits: ported changeset code into pyramid views. 
- refactored part of naming to use commit_id instead of revision
- renamed some parts to repo_commits instead of changeset without breaking backward compat
- small improvements and fixes for tests
 2017-07-24 17:04:14 +02:00
Marcin Kuzminski
a9064c5007 translation: unified usage of pluralize function ungettext. 
- now it's consistent _ungettext for pylons and pyramid
- will allow easier migration to full pyramid codebase
 2017-07-24 10:00:06 +02:00
Lisa Quatmann
666cb615d5 styling: updated old icons based on the new definitions. 
- making things look nicer.
 2017-07-19 22:54:49 +02:00
Marcin Kuzminski
b2714a3c1d changelog: ported to pyramid views. 2017-07-18 00:07:43 +02:00
Marcin Kuzminski
0b2c148765 pyramid: stop relying on global mako url() function. 
- use only the helpers method
 2017-07-12 23:46:34 +02:00
Daniel Dourvaris
372c7c267c tooltip: use consistent h.tooltip usage to set tooltips. 2017-06-28 21:02:21 +02:00
Marcin Kuzminski
5915f38fcf pull-request-api: updated logic of closing a PR via API call. 
- consistent logic via web and API
- updated events
- updated proper close checks.
 2017-06-13 00:14:21 +02:00
Marcin Kuzminski
53d41696e0 pull-requests: expose author in creation view to be consistent with show view. 2017-06-07 14:35:27 +02:00
Marcin Kuzminski
53b4ac98f8 repo-summary: re-implemented summary view as pyramid. 
- changed exception handler, to now work in pure pyramid mode
- changed missing requirements logic on repo based views that require vcs-connection
 2017-06-07 13:23:21 +02:00
Marcin Kuzminski
bd1e865c9c pull-request: extended default reviewers functionality. 
- added mandatory reviewers JS logic Fixes: #4219
- added option to forbid author to be a reviewer via JS/Frontend checks. Fixes #5190
- added option to forbid adding new reviewers except those defined. Fixes #5208
 2017-05-29 20:10:17 +02:00
Marcin Kuzminski
be41f0b920 pull-requests: moved the listing of pull requests for repo into pyramid. 
- moved as datagrid App
- changed loading of grid to lazy, as other new views.
 2017-05-29 20:58:42 +02:00
Marcin Kuzminski
0b80fe66c9 pull-request-reviewers: added option to add reviewers by picking an user group for pull requests. 
- fixes #5228
 2017-04-19 17:30:07 +02:00
Marcin Kuzminski
9f40d6928b pull-request: force update pull-request in case of the target repo reference changes. 
- We should be able to force update a diff if the target repo reference changes. It
will help detect commits that are pushed into the target from the origin.
- Fixes #5266
 2017-04-04 16:38:32 +02:00
Marcin Kuzminski
32d888e8e2 pull-requests: show common ancestor inside pull-request view. 
- common ancestors helps to determine what is a base of compare.
 2017-04-04 15:52:08 +02:00
Marcin Kuzminski
4c2e5ee660 pull-request: lock button when updating reviewers to forbid multi-submit. 
- fixed some small UI issues found.
 2017-03-27 15:32:27 +02:00
Marcin Kuzminski
73ef8af50c pull-requests: disable processing of grid when used with server side. 2017-03-07 17:53:14 +01:00
Marcin Kuzminski
eb8c2fe3d1 helper-blocks: fix pre formatting only for auth plugin helper texts. 
- leave other as they can break if we apply same for all helper blocks.
 2017-02-25 10:20:10 +01:00
Marcin Kuzminski
2e08f6bd4a ui: use monospace fonts on clone urls. 2017-02-24 14:33:06 +01:00
Marcin Kuzminski
7a52541b06 pull-requests: show version age component should use local dates. 2017-02-17 11:18:11 +01:00
Marcin Kuzminski
89dc191e0d pull-requests: add explicit CLOSE pr action instead of closed status from selector. 
- This is much better UX
- we set status based on calculated review
- fixes #5215
 2017-02-15 11:48:54 +01:00
Marcin Kuzminski
4da039bc7e comments: fix scroll to comments that are outdated. Auto-show them on scroll. 2017-02-01 21:21:45 +01:00
Marcin Kuzminski
2d4747cc69 pr-versioning: move version controller to dedicated PR file 2017-01-30 13:04:12 +01:00
Marcin Kuzminski
8afad62984 pr-versioning: ux better selectors 2017-01-26 12:53:43 +01:00
Marcin Kuzminski
abda1c528f pr-versioning: link-changes 2017-01-25 21:45:47 +01:00
Marcin Kuzminski
e7511ca6f6 pr-versioning: implemented versioning for pull requests. 
- users can navigate via each version or generate diffs between versions
- diff between versions will show changed commits and partial diffs
- redone the UI for versioning a bit
- small UI fixes
 2017-01-25 19:06:59 +01:00
Marcin Kuzminski
a044290ee2 comments: show links to unresolved todos 
- show hidden comments when using navigation for comments
- small UI fixes
 2017-01-19 13:59:02 +01:00
Marcin Kuzminski
30637758d6 pull-requests: unified merge checks. 
- same logic is now used for API, pre-conditions on show, and checks on actual merge
- added checks into API because it was not validated
 2017-01-18 14:56:20 +01:00
Marcin Kuzminski
e5f1efc7f7 pull-request: introduced new merge-checks. 
- merge checks show nicer UI for status of merge approval inside PR
- merge checks now also forbid a merge if TODO notes are present
- use global refresh merge check when submitting comments. It
  no longer required page reload when submitting status change.
 2017-01-16 22:58:44 +01:00
Marcin Kuzminski
e8447b4107 comments: use unified aggregation of comments counters. 
- use 1 source of count and display objects
- scroll to for hidden comments will show them before scroll
- properly show how many comments we're displaying for each version
 2017-01-16 18:12:38 +01:00
Marcin Kuzminski
e03415a797 pull-requests: fixed small UI issues in case of missing commits inside a Pull request. 2017-01-08 22:12:32 +01:00
Marcin Kuzminski
f26ac86e28 comments: properly show version of pull request into added comments. 
- index them by numeric index instead of DB id
- show inside main comments a version in which they were made.
 2017-01-08 21:49:26 +01:00
Marcin Kuzminski
a3624ab66c html: fixed found syntax problems 2017-01-04 22:45:53 +01:00
Marcin Kuzminski
89e2586781 templating: use .mako as extensions for template files. 2017-01-04 22:13:57 +01:00
Marcin Kuzminski
7dc34b039c pull-requests: wait for all dynamic checks before enabling opening a PR. 2017-01-02 19:56:31 +01:00
Marcin Kuzminski
3761402390 pull-requests: updated versioning support. 
- each pr version connects invalidated comments to it
- in version list we show number of comments made on each version
- show all outdated comments even for deleted files
- linkify outdated comments to first one
- added auto-collapse of commit range if they are more than 5
- styling changes, wide mode improvements
 2016-12-30 12:11:15 +01:00
Marcin Kuzminski
62db642312 pull-requests: show only selected pr version to save space. 
- users usually don't want to see all versions
- add expand show all to display full list
 2016-12-23 16:29:51 +01:00
Marcin Kuzminski
e44090dfe8 diffs: compare overhaul. 
- made compare and commit range pages more consistent with other commit diff pages
- removed mergerly, closes #4665. Old diff2way is replaced by new diffs with
  side-by-side mode.
- cleanup button behaviour on compare page. Added help text and
  generally improved UX
- switched file-diffs to compare page with file filter. Part of #4000
- added collapse/expand commits buttons in compare views.
 2016-12-22 23:48:05 +01:00
Marcin Kuzminski
9d8634a618 pull-requests: expose version browsing of pull requests. 
- show nav for browsing each version of pr
- show detailed changes for each of version
- update comment template to indicate the changes were due to update of a pr
 2016-12-19 17:38:22 +01:00
Marcin Kuzminski
8b2182110a pull-requests: added version browsing for pull requests. 
- invalidated comments now link to previous version to show code context
- removed all deprecated JS code left from new diffs
- improved invalidated comments display logic
- UI tweaks
 2016-12-06 00:22:04 +01:00
Daniel Dourvaris
e5b972cd38 ux: fix show inline comments link 2016-11-27 11:08:43 +02:00
Daniel Dourvaris
c5cdd9695a diffs: add new diffs to pull request page 2016-11-25 11:14:04 +02:00
Marcin Kuzminski
510f700051 pull-requests: moved the delete logic into the show view. 
- delete from pr view is more intuitive
- there was several support queries about beeing confused how to delete a pr
 2016-10-30 20:58:11 +01:00
Martin Bornhold
ff69018a3e pr-shadow: Adapt to new merge response object. 2016-10-23 16:03:46 +02:00
Martin Bornhold
7dfbea5041 pr-shadow: Display link to last merge revision in shadow repository if merge was successful. #1055 2016-10-23 14:38:52 +02:00