Commit graph

82 commits

Author SHA1 Message Date
Marcin Lulek
b95942a08c pull-requests: security, prevent from injecting comments to other pull requests users
don't have access to.
2017-10-19 08:56:32 +02:00
Marcin Lulek
35981bbe7a pull-requests: security double check permissions on injected forms of source and target repositories. 2017-10-17 20:32:59 +02:00
Marcin Kuzminski
e6fa851ff8 db: prevent empty IN queries that generally are performance problem, and triggers sql warnings. 2017-10-17 20:32:23 +02:00
Marcin Kuzminski
69a865a7a3 repo-groups: moved to pyramid 2017-10-17 14:06:51 +02:00
Marcin Kuzminski
6bfda00b7a repo-forks: security, check for access to fork_id parameter to prevent
resource discovery.
2017-10-15 19:40:57 +02:00
Marcin Kuzminski
b326189910 repo-forks: security, fix issue when forging fork_repo_id could allow reading
other people forks.
2017-10-15 18:54:52 +02:00
Marcin Kuzminski
4dbba20bd3 repo-settings: fix error on passing in _anchor into wrong call.
Needs to be for routing and not for HttpFound.
2017-10-14 22:42:29 +02:00
Marcin Kuzminski
27aff1de7a pull-requests: trigger merge simulation during PR creation. Fixes #5396 2017-10-12 20:57:02 +02:00
Marcin Kuzminski
c66d2e978e files: prevent XSS in fake errors message on filenodes. 2017-10-09 22:37:05 +02:00
Marcin Kuzminski
abf63a445f audit-logs: expose tailoed audit logs in repository view 2017-10-08 12:11:04 +02:00
Marcin Lulek
b900d908c5 security: fix XSS in repo strip view. 2017-10-07 13:14:08 +02:00
Marcin Kuzminski
fe428ab4d7 files: protect against 500 errors on nodelist. 2017-10-07 10:33:47 +02:00
Marcin Kuzminski
10231cba28 changelog: prevent from 500 errors on changelog when fetching certain commits. 2017-10-07 10:13:39 +02:00
Marcin Kuzminski
eb50f6c575 commits: add protection against 500 errors on commit children/parents page. 2017-10-06 15:44:17 +02:00
Marcin Kuzminski
3fea802084 repo-summary: protect against wrong commits in repo summary. 2017-10-06 15:02:25 +02:00
Marcin Kuzminski
862e0c122b commits: hide evolve commits. Fixes #5392 2017-10-03 16:37:39 +02:00
Marcin Kuzminski
6eac893f8f changelog: fix consistency of returned data to 2 element tuple. 2017-09-27 17:26:07 +02:00
Marcin Kuzminski
3783c23d90 changelog: only load graph data when showing changelog for both commit and commit loaded via ajax chunks. 2017-09-27 13:28:45 +02:00
Marcin Kuzminski
3718a47d3f changelog: fix and optimize loading of chunks for file history.
- load-next/prev wasn't working
- make sure pagination works as expected
- speed up certain actions by pre-loading more attributes
2017-09-27 13:21:57 +02:00
Marcin Kuzminski
59ed8f2d47 changelog: fix url generation for file changelog and ensure
http redirect works as expected for unfound nodes.
2017-09-25 13:55:31 +02:00
Marcin Kuzminski
37ef509c3f tests: fixed some more test issues during stress tests runs. 2017-09-21 11:52:32 +02:00
Marcin Kuzminski
3821db3f37 apps: removed deprecated usage of c.repo_info 2017-09-08 13:33:17 +02:00
Marcin Kuzminski
87a5eb4bde apps: cleanup imports 2017-09-08 12:56:47 +02:00
Marcin Lulek
a307f2677c feeds: generate entries with proper unique ids.
- fixes #5379
2017-09-01 16:05:06 +02:00
Marcin Kuzminski
57031945a3 pull-requests: use merge info to show how Pull requests will be merged.
- rebase or merge commit is shown as merge strategy.
- close/delete branch are shown if that option is selected.
2017-08-23 13:48:10 +02:00
Marcin Kuzminski
c7704859cf pull-requests: in case of an error redirect to the same url as source.
- will keep the bookmark/branch info, and help re-select proper revisions.
2017-08-23 12:31:38 +02:00
Marcin Kuzminski
5a490b42a4 pull-requests: redirect to repo PR after delete instead of my account. 2017-08-22 22:29:38 +02:00
Marcin Kuzminski
34a59d2066 compare: make sure to not do any redirects for XHR requests types.
This can lead to page-in-page rendering when using ajax compare loading.
2017-08-23 13:02:37 +02:00
Marcin Kuzminski
928129ed6c repositories: rewrote whole admin section to pyramid.
- fixed few small found problems
- code cleanups
2017-08-11 13:00:47 +02:00
Marcin Kuzminski
ee0e7c21f8 users: make AuthUser propert a method, and allow override of params. 2017-08-03 20:17:46 +02:00
Marcin Kuzminski
1c20025ca7 pyramid: use a faster scan method for faster app start. 2017-08-02 11:01:36 +02:00
Marcin Kuzminski
05386904e7 forks: moved pylons code into pyramid. 2017-08-01 11:48:16 +02:00
Marcin Kuzminski
3430eb74e5 repositories: ported repo_creating checks to pyramid.
- fixed security issues with resource discovery.
- ported repository creating check into base view for repos.
2017-07-28 15:56:06 +02:00
Marcin Kuzminski
21efeeab37 repositories: handle in a nicer way a filesystem damaged repositories.
- redirect with proper flash message about damaged filesystem.
2017-07-28 15:23:45 +02:00
Marcin Kuzminski
015ea42459 pull-request: code cleanup
- use stricter checks
- pull_request_id should be taken from object to cast to INT
- unified some code usage
2017-07-27 22:48:09 +02:00
Marcin Kuzminski
b8804925c3 pull-requests: fix deletion of comments and make the test actually test this !
- broken test failed to detect obvious error on comment deletion
2017-07-27 14:46:02 +02:00
Marcin Lulek
e4f789f3f7 pull-requests: fixed tests. 2017-07-27 14:39:21 +02:00
Marcin Kuzminski
b203d5f208 pull-requests: migrated code from pylons to pyramid 2017-07-27 11:30:55 +02:00
Daniel Dourvaris
891de4a613 files: fixed few found issues.
- ensure non-relative paths are used after migration
- redirect to summary for empty repositories instead of commit page that gives 404
2017-07-26 18:06:16 +02:00
Marcin Kuzminski
93c5a7f9c5 compare: migrated code from pylons to pyramid views. 2017-07-26 13:28:45 +02:00
Marcin Kuzminski
4de255d013 core: no longer rely on webob exception inside get_or_404 function.
- relly on pyramid exc only
- helps reduce number of appenlight problems with 404 handling via webob
2017-07-25 15:26:38 +02:00
Marcin Kuzminski
8efc4d92c5 repo-commits: ported changeset code into pyramid views.
- refactored part of naming to use commit_id instead of revision
- renamed some parts to repo_commits instead of changeset without breaking backward compat
- small improvements and fixes for tests
2017-07-24 17:04:14 +02:00
Marcin Kuzminski
49a76c81fe views: fixed some view names for better usage in view whitelist access 2017-07-24 12:28:57 +02:00
Marcin Kuzminski
cf9b29a5bc tests: lazy load the JSON history for tests.
- loading on module level makes this evaluated every time we start the server.
2017-07-18 00:21:30 +02:00
Marcin Kuzminski
b2714a3c1d changelog: ported to pyramid views. 2017-07-18 00:07:43 +02:00
Marcin Kuzminski
678a930750 routing: use a common method to extract the f_path for repo views.
The extra slashes can cause odd issues with GIT, the previous
pylons code had a fix in routing. This ports this fix into
pyramid helper in base app.
2017-07-17 23:09:33 +02:00
Marcin Kuzminski
53611d6f94 files: ported repository files controllers to pyramid views. 2017-07-17 14:20:22 +02:00
Marcin Kuzminski
93de470b3f tests: fixed few possible cases of detached instance errors. 2017-07-12 16:32:06 +02:00
Daniel Dourvaris
81fa857318 repo-feed: moved from pylons controller to pyramid views. 2017-07-09 10:25:14 +02:00
Marcin Kuzminski
ef1f17e46a refs: refactored references code to remove any pylons elements.
- now uses pure pyramid style without usage of any pylons globals
2017-07-08 15:28:40 +02:00