engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4772 commits 1 branch 0 tags 110 MiB
Commit graph

64 commits

Author SHA1 Message Date
Milka Kuzminski
295f94aea6 comments: add ability to resolve todos from the side-bar. 2021-02-03 15:14:34 +01:00
Milka Kuzminski
586719d33a drafts: sidebar functionality 2020-11-16 10:50:44 +01:00
Milka Kuzminski
6cf496d104 notifications: skip double rendering just to generate email title/desc 2020-11-11 22:44:38 +01:00
Milka Kuzminski
b8ef1f16ea comments: don't mark draft comments as outdated. 2020-11-05 15:05:07 +01:00
Milka Kuzminski
1d6df06614 comments: counts exclude now draft comments, they shouldn't be visible. 2020-10-30 09:36:31 +01:00
Milka Kuzminski
afd3357349 comments: introduce new draft comments. 
- private to author
- not triggering any notifications
- sidebar doesn't display draft comments
- They are just placeholders for longer review.
 2020-10-21 17:53:23 +02:00
Marcin Kuzminski
16678eb0f8 reviewers: use common function to obtain reviewers with filter of role. 2020-10-08 14:10:11 +02:00
Marcin Kuzminski
5e7cb0b2a0 pull-requests: use count only for comments related to display grids on my account and repo view. 2020-10-06 14:14:01 +02:00
Marcin Kuzminski
9692332a7b channelstream: cleanup, and re-organize code for posting comments/pr updated messages. 
- now shares new common code
- fixed cases for both views and API in consistent way
 2020-10-06 11:54:29 +02:00
Marcin Kuzminski
80da773011 reviewers: added observers as another way to define reviewers. 
- fixes #4183
 2020-10-06 08:49:13 +02:00
Marcin Kuzminski
f634c67b68 commits/pr pages various fixes. 
- added navbar to commit page
- improvements on UI
- code cleanups
 2020-09-23 11:45:43 +02:00
Marcin Kuzminski
9430615145 pull-requests: overhaul of the UX by adding new sidebar 
- sidebar aggregates comments, todos, observers, referenced tickets, and reviewers
- live components push now comments, reviewer presence, and todo live via channelstream
- sidebar is collapsable, and stored in user session
- simplified number of information on the pull request page
- fixed and cleanup of the outdated comments and at version comments that in some cases reported wrong version assignment.
 2020-09-01 12:09:40 +02:00
Marcin Kuzminski
9106e99baf pull-requests: added observers, and fix few problems with versioned comments 2020-08-21 20:56:59 +02:00
Marcin Kuzminski
50d91914f5 emails: set References header for threading in mail user agents even with different subjects 
- drop template headers() function as it wasn't used, and actually had bad implementation
 2020-07-15 21:37:03 +02:00
Marcin Kuzminski
74e96ea4b4 comments: added new events for comment editing to handle them in integrations. 2020-07-13 11:18:28 +02:00
Marcin Kuzminski
7c55d3dab0 comments-api: make edit API resilent to bad version data. 2020-07-14 10:40:05 +02:00
Marcin Kuzminski
40505633d1 comment-history: fixes/ui changes 
- show explicit version conflicts
- use new select2 based dropdown with nicer formatting
- enabled editing of content for TODO comments
 2020-06-23 17:43:06 +02:00
Marcin Kuzminski
29356473c4 comments: save modification date for main comment on edit. 2020-06-23 11:46:00 +02:00
Bartłomiej Wołyńczyk
b9a819cbfe comments: edit functionality added 2020-05-27 23:47:09 +02:00
Marcin Kuzminski
fe96e16646 code: update copyrights to 2020 2020-04-16 00:34:52 +02:00
Daniel Dourvaris
466826a84a hooks: added new hooks for comments on pull requests and commits. 
- allows writing custom actions on top of comments
- new rcextension hooks
- organized and renamed some hooks
- new helpers for rcextensions
- fixes #5583
 2020-04-15 18:00:59 +02:00
Daniel Dourvaris
603a3c0545 emails: added reply link to comment type emails 
- also added note/todo ID in display
- cleanup code for anchor resolution, and selected elements highlight
 2019-11-08 13:05:34 +01:00
Marcin Kuzminski
697ce81998 api: allow extra recipients for pr/commit comments api methods 
- adds some sort of CC functionality for notification
- allows sending emails with notifications to people who are not commit messages, or pr reviewers e.g project manager etc.
 2019-11-07 22:29:39 +01:00
Daniel Dourvaris
453a6ee9a2 emails: updated emails design and data structure they provide. 
- more consistent UI for emails
- nicer formatting, plaintext emails
- major cleanup and fixes lots of incosistencies
- additionally debug-style now allows to test emails in browser for faster development
 2019-11-05 19:07:09 +01:00
Marcin Kuzminski
000b072a3f comments: re-implemented diff and comments/todos in pull-requests. 2019-08-13 12:45:25 +02:00
Marcin Kuzminski
4174ab0239 ui: new commits page. 
- changes according to design
- consistency, space saving etc
 2019-08-06 12:20:29 +02:00
Marcin Lulek
e303ffca3f comments[security]: make an additional check to forbid solving comments from other repo scope. 2019-03-11 08:46:12 +01:00
Marcin Kuzminski
f38e87b9b7 api: added function to fetch comments for a repository. 2019-01-28 12:05:34 +01:00
Marcin Kuzminski
6e8560f3a5 comments: expose a function to fetch unresolved TODOs for repository 2019-01-25 14:19:30 +01:00
Marcin Kuzminski
bd1a9c8201 docs: updated copyrights to 2019 2019-01-02 18:13:27 +01:00
Marcin Kuzminski
da773459ae comments: fix extracing auth_user from the passed in objects. Before if auth_user is empty we could relly on INT or STR passed in 2018-09-17 19:05:34 +02:00
Marcin Kuzminski
1a717208f4 audit-logs: store properly IP and user for certain comments types. 
- before mostly IP could be missing from audit log data.
 2018-04-26 00:59:07 +02:00
Marcin Kuzminski
00b45c1fa7 release: update copyright year to 2018 2018-01-19 17:13:16 +01:00
Marcin Kuzminski
90c9124213 events: properly refresh comment object to load it's relationship. 
This prevents from issues of reading associated statuses of comment during
a partial commit (using Session().flush)

- Fixes #5412
 2018-01-06 12:08:49 +01:00
Marcin Kuzminski
90422773df pull-request: verify resolve TODO comment needs to be bound to the same PR as we're calling 2017-12-06 20:06:28 +01:00
Marcin Kuzminski
5f9ae2ae11 pylons: remove pylons as dependency 
- dependencies: bumped:
 -setuptools-scm==1.15.6
 -celery==4.1.0
 -kombu==4.1.0
 -pytz==2017.3
 -Routes==2.4.1

Removed all pylons components. Refactored the code to use only pyramid
parts
 2017-11-15 13:42:54 +01:00
Marcin Kuzminski
2f5d2e7d67 routing: removed more usage of pylons url() objects. 2017-09-20 15:21:03 +02:00
Marcin Kuzminski
2b15a05b94 comments: remove usage of pylons global config. 2017-08-04 14:29:09 +02:00
Marcin Kuzminski
b203d5f208 pull-requests: migrated code from pylons to pyramid 2017-07-27 11:30:55 +02:00
Marcin Kuzminski
fa5dd62880 channelstream: push events with comments on single commits. 
- use wrapper for posting to simplify the code.
 2017-07-26 18:04:56 +02:00
Marcin Kuzminski
aa3bffd198 pull-requests: prepare the migration of pull request to pyramid. 
- this is half the code because of problems found during porting
- partially moved the urls, and flipped the logic into pyramid code
- needs more work in core for full switch.
 2017-06-19 13:25:15 +02:00
Marcin Kuzminski
926a79e98e audit-logs: implemented pull request and comment events. 2017-06-17 15:22:50 +02:00
Marcin Kuzminski
47f9f32ad9 events: expose permalink urls for different set of object. 
- permalink url should provide a non-changeable url that can be used in
external sources with guarantee of beeing always valid.
 2017-06-08 16:11:33 +02:00
Marcin Kuzminski
53b4ac98f8 repo-summary: re-implemented summary view as pyramid. 
- changed exception handler, to now work in pure pyramid mode
- changed missing requirements logic on repo based views that require vcs-connection
 2017-06-07 13:23:21 +02:00
Marcin Kuzminski
8c73a665d3 emails: added note types into emails. Fixes #5221 2017-02-17 17:15:05 +01:00
Marcin Kuzminski
9c43777217 commit-page: show unresolved TODOs on commit page below comments. 2017-02-01 13:09:54 +01:00
Marcin Kuzminski
e63934c25b todos: all todos needs to be resolved for merge to happen. 
This will prevent the outdated todos beeing automatically marked as solved becuase of bigger diff
changes. It's better to mark commits quickly as resolved instead of potentially have unresolved todos hidden
because of invlidation logic.
 2017-01-19 13:57:46 +01:00
Marcin Kuzminski
e5f1efc7f7 pull-request: introduced new merge-checks. 
- merge checks show nicer UI for status of merge approval inside PR
- merge checks now also forbid a merge if TODO notes are present
- use global refresh merge check when submitting comments. It
  no longer required page reload when submitting status change.
 2017-01-16 22:58:44 +01:00
Marcin Kuzminski
e8447b4107 comments: use unified aggregation of comments counters. 
- use 1 source of count and display objects
- scroll to for hidden comments will show them before scroll
- properly show how many comments we're displaying for each version
 2017-01-16 18:12:38 +01:00
Marcin Kuzminski
8f1db17117 comments: allow submitting id of comment which submitted comment resolved. 
- use common template for inject forms
- cleanup of JS models, bind class of Form into the form itself
 2017-01-11 15:05:33 +01:00