- fixes Mercurial CVE for lack of permissions checking on mercurial batch commands
- more strict checks for permissions, now default to push instead of pull
to be always on safe side.
- decypher batch commands and pick top-most permission to be used
- This change will allow SVN to execute rhodecode integration framework
via executing the builting hooks.
- uses txn_id for svn to provide metadata required via Apache
- Interception of SVN transaction is required to use temporary stores for metadata
- hooks are now part of vcsserver where the install/control logic is stored
- this solves a case when SVN repository needs to find out a repo without
per-repo settings available
- we need to get the global config first to be able to extract repo name
- dependencies: bumped:
-setuptools-scm==1.15.6
-celery==4.1.0
-kombu==4.1.0
-pytz==2017.3
-Routes==2.4.1
Removed all pylons components. Refactored the code to use only pyramid
parts
Based on my original research, this was the "minimal" starting point. It shows
that three concepts are needed for the "repo_name":
* From the security standpoint we think of the shadow repository having the same
ACL as the target repository of the pull request. This is because the pull
request itself is considered to be a part of the target repository.
Out of this thought, the variable "acl_repo_name" is used whenever we want to
check permissions or when we need the database configuration of the
repository. An alternative name would have been "db_repo_name", but the usage
for ACL checking is the most important one.
* From the web interaction perspective, we need the URL which was originally
used to get to the repository. This is because based on this base URL commands
can be identified. Especially for Git this is important, so that the commands
are correctly recognized.
Since the URL is in the focus, this is called "url_repo_name".
* Finally we have to deal with the repository on the file system. This is what
the VCS layer deal with normally, so this name is called "vcs_repo_name".
The original repository interaction is a special case where all three names are
the same.
When interacting with a pull request, these three names are typically all
different.
This change is minimal in a sense that it just makes the interaction with a
shadow repository barely work, without checking any special constraints yet.
This was the starting point for further work on this topic.
This custom header sets the SCM backend which is in use. It is used to identify
VCS responses in the error handler. VCS responses are skipped during error handling.
- vcs middleware now returns dummyHandler if not configured
- propagate the per-repo vcs related configs into VCSMiddleware
- moved the forms arround and group things into more logical blocks
