Marcin Kuzminski
e9cf83badc
diffs: fixed outdated files in pull-requests re-using the filediff raw_id for anchor generation.
...
In some cases when there are no longer any files this caused error since filediff wasn't present.
In addition this generated wrong ids since it used a last-defined attribute on a for loop.
Fixes #5567
2019-09-25 10:33:00 +02:00
Marcin Kuzminski
000b072a3f
comments: re-implemented diff and comments/todos in pull-requests.
2019-08-13 12:45:25 +02:00
Marcin Kuzminski
4174ab0239
ui: new commits page.
...
- changes according to design
- consistency, space saving etc
2019-08-06 12:20:29 +02:00
Daniel Dourvaris
9aad34b4bd
ui: fixed some missed icons during redesign phase
2019-07-04 21:14:56 +03:00
Marcin Kuzminski
ef9b0f8cd8
diffs: store wide-diff mode in user sessions for saved state.
2019-04-23 11:26:12 +02:00
Daniel Dourvaris
96fa4e0bdc
py3: remove usage of basestring
2019-01-22 23:06:49 +01:00
Daniel Dourvaris
f2c8c96013
Diffs: fixed missing limited diff container display on large diffs
2019-01-07 13:41:12 +01:00
Marcin Kuzminski
596657fd2c
security: fixed xss in context diff menu.
2018-12-27 17:38:19 +01:00
Marcin Kuzminski
4fb98500a9
diffs: fixed scope mismatch for diff navigation
2018-10-25 18:03:30 +02:00
Marcin Kuzminski
f0b9af7b4b
compare: fixed case of cross repo compare before links not working.
2018-10-24 14:13:47 +02:00
Daniel Dourvaris
07fea8c47c
diffs: exclude +/- from diffs generation and make then a non-selectable markers visible only via CSS.
2018-10-23 15:08:18 +02:00
Daniel Dourvaris
94d74336d1
diffs: introducing diff menu for whitespace toggle and context changes
2018-10-23 17:02:26 +02:00
Marcin Kuzminski
d0e88116f8
diffs: make line anchors commit aware. This fixes duplicate anchor problem on range diffs.
2018-10-17 13:49:16 +02:00
Daniel Dourvaris
c48ba139c7
diffs: update all sticky elements on dom changes to handle cases like:
...
- collapsed diffs
- comments
- collapsed large diffs
2018-10-17 06:57:18 +02:00
Daniel Dourvaris
40ed27c0a9
diffs: ui improvements over the sticky header.
2018-10-16 22:29:18 +02:00
Marcin Kuzminski
797a4ff7ab
diffs: sticky top-file bar + context aware file labels.
...
- when browsing diffs now we show context file path so every time you know what file diff you're seeing
- block file selector on range diffs
- update bower packages
2018-10-16 18:24:44 +02:00
Marcin Kuzminski
9014d9516c
pull-requests: allow to show range diff in pr view
2018-10-15 12:44:36 +02:00
Daniel Dourvaris
5e88268e1f
diffs: made pills display on single side. Better UX and readability.
2018-10-09 15:45:11 +02:00
Marcin Kuzminski
d793ec4f31
core: stop using deprecated .revision
2018-10-01 15:57:56 +02:00
Marcin Lulek
e9f80c1525
diffs: added handy quick file selector in diffs views.
2018-10-01 10:15:33 +02:00
Marcin Kuzminski
4c45a5dbea
users: use new session store for temporary settings for users.
...
- use for clone url type selection
- use for diffs mode
2018-09-24 23:18:38 +02:00
Marcin Kuzminski
25edeca2ca
diffs: small UI fixes
2018-09-24 15:35:37 +02:00
Marcin Kuzminski
01bb7220b2
diffs: don't use highlite on the new ops lines
2018-09-24 17:49:14 +02:00
Marcin Kuzminski
4f428a0e1a
comments: allow commenting on empty files without content.
2018-09-24 14:34:02 +02:00
Marcin Kuzminski
7da6de8350
comments: ensure we ALWAYS display unmatched comments.
2018-09-24 12:40:08 +02:00
Marcin Kuzminski
f23a40e0b7
pull-requests: fixed case of unresolved comments attached to removed file in pr.
...
- This makes removed files that still have unresolved TODO visible. Before
those file were hidden and unable to merge because of TODO requirements.
2018-06-19 12:35:45 +02:00
Bartłomiej Wołyńczyk
4637dd151e
caching: add option to cache diffs for commits and pull requests.
...
- new option for vcs settings to enable caching of diffs and commits
- enables auditing of PR after closing it, and removing commits from source repo
- speed up for large PR upto 20x
- reduced memory usage
2018-04-17 18:46:20 +02:00
Marcin Kuzminski
da3101e51f
diffs/files: fix and improve line selections and anchor links.
2018-02-27 14:54:15 +01:00
Sandu Turcan
e4981d4e72
path-permissions: Initial support for path-based permissions
2018-02-18 19:30:42 -05:00
Marcin Kuzminski
ed3ad2ed9a
diffs: inidicate visually outdated comments in the icon.
2018-02-20 12:02:14 +01:00
Marcin Kuzminski
8e40a60b08
comments: place the left over comments (outdated/misplaced) to the left or right pane.
...
So we don't loose the original context where they were placed.
2017-11-17 18:37:50 +01:00
Marcin Kuzminski
555d3417ad
routing: deprecate url_replace function in exchange of current_route_path which we now use in pyramid
2017-11-07 13:38:01 +01:00
Marcin Kuzminski
2a06b6b96d
diffs: show copy-to-clipboard next to diff files
2017-09-21 23:29:44 +02:00
Marcin Kuzminski
26635ebc3e
routing: remove usage of url.current from pylons.
2017-09-20 15:44:49 +02:00
Marcin Kuzminski
2f5d2e7d67
routing: removed more usage of pylons url() objects.
2017-09-20 15:21:03 +02:00
Marcin Kuzminski
8efc4d92c5
repo-commits: ported changeset code into pyramid views.
...
- refactored part of naming to use commit_id instead of revision
- renamed some parts to repo_commits instead of changeset without breaking backward compat
- small improvements and fixes for tests
2017-07-24 17:04:14 +02:00
Marcin Kuzminski
3b524b7875
renderer: remove usage of old non request PartialRenderer
2017-07-24 09:59:48 +02:00
Marcin Kuzminski
a9064c5007
translation: unified usage of pluralize function ungettext.
...
- now it's consistent _ungettext for pylons and pyramid
- will allow easier migration to full pyramid codebase
2017-07-24 10:00:06 +02:00
Marcin Kuzminski
53611d6f94
files: ported repository files controllers to pyramid views.
2017-07-17 14:20:22 +02:00
Marcin Kuzminski
f53db19687
diffs: simplified the datastructure of fillediff. Hopefully this
...
will allow better Garbage Collection.
2017-06-28 14:03:57 +02:00
Daniel Dourvaris
372c7c267c
tooltip: use consistent h.tooltip usage to set tooltips.
2017-06-28 21:02:21 +02:00
Marcin Kuzminski
feb25a9cb8
diffs: support mercurial copy in diffs details.
2017-03-28 22:37:33 +02:00
Marcin Kuzminski
1d8f00e026
annotation: added shortcut links to browse the annotation view with previous commits.
2017-02-07 22:51:07 +01:00
Marcin Kuzminski
1b7412f886
annotations: fixed UI problems in annotation view for newer browsers.
2017-02-07 21:54:05 +01:00
Marcin Kuzminski
e64716029d
pr-diffs: fixed a case when there are outdated comments and we're doing a rebase compare.
2017-01-30 13:55:08 +01:00
Marcin Kuzminski
e7511ca6f6
pr-versioning: implemented versioning for pull requests.
...
- users can navigate via each version or generate diffs between versions
- diff between versions will show changed commits and partial diffs
- redone the UI for versioning a bit
- small UI fixes
2017-01-25 19:06:59 +01:00
Marcin Kuzminski
8f1db17117
comments: allow submitting id of comment which submitted comment resolved.
...
- use common template for inject forms
- cleanup of JS models, bind class of Form into the form itself
2017-01-11 15:05:33 +01:00
Marcin Kuzminski
24ef7171f8
comments: add comments type into comments.
2017-01-11 14:46:29 +01:00
Marcin Kuzminski
f26ac86e28
comments: properly show version of pull request into added comments.
...
- index them by numeric index instead of DB id
- show inside main comments a version in which they were made.
2017-01-08 21:49:26 +01:00
Marcin Kuzminski
a3624ab66c
html: fixed found syntax problems
2017-01-04 22:45:53 +01:00