- made compare and commit range pages more consistent with other commit diff pages
- removed mergerly, closes#4665. Old diff2way is replaced by new diffs with
side-by-side mode.
- cleanup button behaviour on compare page. Added help text and
generally improved UX
- switched file-diffs to compare page with file filter. Part of #4000
- added collapse/expand commits buttons in compare views.
- show nav for browsing each version of pr
- show detailed changes for each of version
- update comment template to indicate the changes were due to update of a pr
- redone the system info page. Errors/Warnings now show next to the
data, and also show up in API call.
- implemented fetching of git/hg/svn version from running vcsserver
- implemented fetching of vcsserver version from itself
- added more warnings/errors detection on RAM/Inodes etc
- few cleanups
* side/side + unified support
* redesign of diff changes/operations
* added button to see file before the change
* auto collapses large diffs
refs #4232
Based on my original research, this was the "minimal" starting point. It shows
that three concepts are needed for the "repo_name":
* From the security standpoint we think of the shadow repository having the same
ACL as the target repository of the pull request. This is because the pull
request itself is considered to be a part of the target repository.
Out of this thought, the variable "acl_repo_name" is used whenever we want to
check permissions or when we need the database configuration of the
repository. An alternative name would have been "db_repo_name", but the usage
for ACL checking is the most important one.
* From the web interaction perspective, we need the URL which was originally
used to get to the repository. This is because based on this base URL commands
can be identified. Especially for Git this is important, so that the commands
are correctly recognized.
Since the URL is in the focus, this is called "url_repo_name".
* Finally we have to deal with the repository on the file system. This is what
the VCS layer deal with normally, so this name is called "vcs_repo_name".
The original repository interaction is a special case where all three names are
the same.
When interacting with a pull request, these three names are typically all
different.
This change is minimal in a sense that it just makes the interaction with a
shadow repository barely work, without checking any special constraints yet.
This was the starting point for further work on this topic.
This custom header sets the SCM backend which is in use. It is used to identify
VCS responses in the error handler. VCS responses are skipped during error handling.
- vcs middleware now returns dummyHandler if not configured
- propagate the per-repo vcs related configs into VCSMiddleware
- moved the forms arround and group things into more logical blocks
