Marcin Kuzminski
dec6e7afda
permissions: rename write+ to write or higher for more explicit meaning.
2020-07-24 12:23:53 +02:00
Daniel Dourvaris
a20d45c20e
notifications: properly inject the custom email headers into templates.
2020-07-24 09:51:14 +02:00
Marcin Kuzminski
bdf49e02d6
emails: added logic to allow overwriting the default email titles via rcextensions.
2020-07-16 12:37:52 +02:00
Marcin Kuzminski
50d91914f5
emails: set References header for threading in mail user agents even with different subjects
...
- drop template headers() function as it wasn't used, and actually had bad implementation
2020-07-15 21:37:03 +02:00
Marcin Kuzminski
aae4c3e227
comments: added rcextensions hoooks for comment editing, and renamed methods to remove odd log_ prefix which
...
isn't exactly what those functions were actually doing.
2020-07-14 11:24:40 +02:00
Marcin Kuzminski
74e96ea4b4
comments: added new events for comment editing to handle them in integrations.
2020-07-13 11:18:28 +02:00
Marcin Kuzminski
7c55d3dab0
comments-api: make edit API resilent to bad version data.
2020-07-14 10:40:05 +02:00
Marcin Kuzminski
9cadf302eb
api: added get_comment method, and return versions for comments to allow simple edits via API.
2020-07-10 11:49:52 +02:00
Marcin Kuzminski
3ca5ca1105
pull-requests: changed the order of close-branch after merge, so we don't leave open heads.
...
Branches will be closed, and then merged based on the close commit. This is a proper and recommended
workflow for feature branches and close option.
2020-07-09 13:09:14 +02:00
Marcin Kuzminski
3708c3660d
emails: reduce warning logs on pre-mailer.
2020-07-09 11:51:23 +02:00
Marcin Kuzminski
119f11f756
auth-tokens: expose all roles with explanation to help users understand it better.
2020-07-07 13:04:19 +02:00
Marcin Kuzminski
4fac5279f8
permissions: flush all when running remap and rescan.
2020-07-06 11:36:55 +02:00
Daniel Dourvaris
5d5bf456a6
permissions: allow users to update settings for repository groups they still own, or have admin perms, when they don't change their name.
...
- this before gave no-permission errors as the parent group access was checked
- since the group parent permission should be checked at creation, or name change this commit fixes such case
2020-07-02 11:39:35 +02:00
Daniel Dourvaris
0c823eb312
permissions: explain better what is inactive duplicate in permissions, sort them to last positions, and make them less visible.
2020-07-01 12:44:50 +02:00
Marcin Kuzminski
986afbcb12
repositories: allow updating repository settings for users without store-in-root permissions
...
in case repository name didn't change.
- when an user owns repository in root location, and isn't allow to create repositories in root
before we failed to allow this user to update such repository settings due to this validation.
We'll now check if name didn't change and in this case allow to update since this doesn't store any new
data in root location.
2020-06-25 10:21:46 +02:00
Marcin Kuzminski
5ae2adddf3
comments: made few UI changes/improvements for how we show comments status, ribbons and general comment data.
2020-06-24 14:19:56 +02:00
Marcin Kuzminski
40505633d1
comment-history: fixes/ui changes
...
- show explicit version conflicts
- use new select2 based dropdown with nicer formatting
- enabled editing of content for TODO comments
2020-06-23 17:43:06 +02:00
Marcin Kuzminski
29356473c4
comments: save modification date for main comment on edit.
2020-06-23 11:46:00 +02:00
Bartłomiej Wołyńczyk
b9a819cbfe
comments: edit functionality added
2020-05-27 23:47:09 +02:00
Marcin Kuzminski
8e312294e7
default-reviewers: fixed problems with new diff format for more advanced default reviewer rules.
2020-06-12 22:14:48 +02:00
Marcin Kuzminski
e3b079f978
landing-refs: create helpers for landing ref to make clear indication about type/name
2020-06-03 10:59:50 +02:00
Daniel Dourvaris
03f066ce9a
users: added option to detach pull requests for users which we delete.
...
- as bonus added ability to specify new owner via ?detach_user_id=NUM GET param.
2020-05-20 12:33:43 +02:00
Marcin Kuzminski
293a3535ae
pull-requests: fix way how pull-request calculates common ancestors.
...
- fixes #5561
- added new preview for size (commits/files) of PRs before opening, this is now based on the special logic that calculates common ancestor and has access to preview diff
- store common ancestor in DB so updates of pull-requests are consistent
2020-05-08 08:43:51 +02:00
Marcin Kuzminski
4b277c70fe
git: fixed readme searcher for libgit2
2020-05-14 09:40:41 +02:00
Marcin Kuzminski
d4eb900e5e
app: use simpler way to extract default_user_id, this will be now registered at server
...
boot.
2020-05-07 15:28:20 +02:00
Marcin Kuzminski
ef2b6c8a1c
comments: added immutable parameter to forbid editing/deleting certain comments
2020-05-05 11:36:32 +02:00
Marcin Kuzminski
72820d2808
pull-requests: allow filter by author
2020-04-24 11:51:37 +02:00
Marcin Lulek
e3169ab897
pull-requests: added filters to my account pull requests page.
2020-04-22 11:10:46 +02:00
Daniel Dourvaris
fcd530ecfe
pull-requests: add information about changes in source repositories in pull-request show page.
...
- fixes #5611
2020-04-21 21:50:36 +02:00
Marcin Kuzminski
324544678c
events: added support for pull-request-comment and commit-comment events.
...
- allows chopts like actions on commits
- re organized events and code cleanups
2020-04-17 22:08:42 +02:00
Marcin Kuzminski
fe96e16646
code: update copyrights to 2020
2020-04-16 00:34:52 +02:00
Daniel Dourvaris
466826a84a
hooks: added new hooks for comments on pull requests and commits.
...
- allows writing custom actions on top of comments
- new rcextension hooks
- organized and renamed some hooks
- new helpers for rcextensions
- fixes #5583
2020-04-15 18:00:59 +02:00
Marcin Kuzminski
1e8d393f02
comments: extend API data with references to commit_id or pull_request_id for audit-logs.
2020-04-15 15:46:53 +02:00
Marcin Lulek
780ec5f73e
core: added user-notice logic to push notice messages.
...
- will be used for exception tracker info
- new version upgrades
- dedicated important messages to the users
2020-04-09 12:30:13 +02:00
Marcin Kuzminski
4de6dd537c
pull-requests: fixed case for GIT repositories when a merge check failed due to merge conflicts the pull request wrongly reported missing commits.
...
- we're now searching for dangling commits in a repo that has them and cannot see them because of failed merge checks.
- pull-request: will save metadata during merge simulation so merge conflicts are permanently stored, and showed to all users.
2020-04-08 11:17:10 +02:00
Daniel Dourvaris
0e39d9274f
notifications: reduce logging for email notifications.
2020-04-03 22:50:43 +02:00
Marcin Kuzminski
d0a117b4ad
exception-tracker: enable send email on exception
2020-03-26 14:03:07 +01:00
Marcin Kuzminski
6a0c148cae
emails: added premailer for inline style formatting to make emails render nicer on all email clients.
2020-03-26 12:40:21 +01:00
Marcin Kuzminski
3b5d294eac
ssh-keys: allow generation of legacy keys for older systems and windows.
2020-02-20 11:13:10 +01:00
Marcin Kuzminski
d3a18067bd
permissions: added helper to fetch users with write permissions. Used mostly in branch protection logic.
2020-02-13 12:55:56 +01:00
Marcin Kuzminski
8c09a544c1
pull-requests: allow super-admins to force change state of locked PRs.
...
- because we still get into that state in some cases, we just create a helper to unlock it easier.
just for super-admins.
2020-02-11 14:34:49 +01:00
Bartlomiej Wolynczyk
e9cb97abbf
descriptions: fixed rendering problem with certain meta-tags.
...
- fixes #5587
- previously escaped values were used for pattern matching, we escape it again to bring old behaviour.
2020-01-28 11:08:05 +01:00
Marcin Kuzminski
8e01135d04
Authentication: cache plugins for auth and their settings in the auth_registry.
...
- Before that change on each requests 4x we loaded plugins for authentication, this hit
many caches, db invalidation context and loaded the plugins logic each time. This was a heavy performance hit
for SVN and other backends as they needed to load that plugins many many times
- Since Authentication plugins almost never change, we'll not store the plugins listed for authentication into
the authnregistry for each process
- For AuthPlugins settings we now also flush plugins settings, and authnregistry cached plugins
2020-01-23 12:41:51 +01:00
Bartlomiej Wolynczyk
bfb50f3681
helpers: pre-compiled issue tracker patterns early for speedup.
2020-01-20 16:50:17 +01:00
Bartlomiej Wolynczyk
347621778d
settings: re-use attached request global config for performance
...
- since we *always* generate a global config and register it into request
make use of it, and not rely on the get_all_settings heavy logic that makes
it slow to fetch because of cache checks.
Within single request we're fine to re-use it when ever request attribute is available
2020-01-20 13:32:49 +01:00
Daniel Dourvaris
c8b4ab6843
API: added pull-requests versions into returned API data
...
- fixes #5582
2020-01-16 08:51:35 +01:00
Marcin Kuzminski
d77223bd2e
pull-requests: small code cleanup to define other type of merge username
...
- possible to specify alternative attr using env option: RC_MERGE_USER_NAME_ATTR
2020-01-10 17:11:43 +01:00
Daniel Dourvaris
67d823a464
users: replaced extraction of user_ids with more efficient method.
...
- by default it extracts only active accounts.
2020-01-10 16:29:01 +01:00
Daniel Dourvaris
0beeba3cdc
permissions: flush all user permissions in case of default user permission changes.
...
- this is a special case that due to inheritance we need to flush ALL users permissions
- before the default permission changes didn't flush the caches result in cached values beeing present until the cache expires
2020-01-10 15:51:14 +01:00
Daniel Dourvaris
a022158f5b
cached-commits: updated logic on cached commit updates.
...
- for repositories we ensure that damaged/empty repositories have initial data instead of now (bug)
- for groups we only update based on first set of data inside a group without iterating to nested objects.
This new logic goes in sync with new update task of groups with automation.
2019-12-27 14:17:10 +01:00