tests: fix tests based on feedback

This commit is contained in:
Andrii V 2025-07-07 20:53:41 +02:00
parent 7bb047808d
commit e830519ae0

View file

@ -171,7 +171,16 @@ def test_slack_pull_request_branch_info_display(app, base_slack_data):
assert "`feature/login-improvements` → `main`" in result.text
def test_slack_pull_request_different_actions(app, base_slack_data):
@pytest.mark.parametrize(
"expected_class",
[
events.PullRequestCreateEvent,
events.PullRequestUpdateEvent,
events.PullRequestMergeEvent,
events.PullRequestCloseEvent,
],
)
def test_slack_pull_request_different_actions(app, base_slack_data, expected_class):
handler = SlackDataHandler()
mock_pr = mock.MagicMock()
@ -181,16 +190,9 @@ def test_slack_pull_request_different_actions(app, base_slack_data):
slack_data = SlackData(title="default", text="default")
branch_info = "`bugfix/JIRA-456` → `develop`"
# Test different PR event types
for event_class in [
events.PullRequestCreateEvent,
events.PullRequestUpdateEvent,
events.PullRequestMergeEvent,
events.PullRequestCloseEvent,
]:
mock_event = mock.MagicMock()
mock_event.__class__ = event_class
mock_event.pullrequest = mock_pr
mock_event = mock.MagicMock()
mock_event.__class__ = expected_class
mock_event.pullrequest = mock_pr
result = handler.format_pull_request_event(mock_event, base_slack_data, slack_data)
assert branch_info in result.text, f"Branch info missing for {event_class.__name__}"
result = handler.format_pull_request_event(mock_event, base_slack_data, slack_data)
assert branch_info in result.text, f"Branch info missing for {expected_class.__name__}"