From e830519ae095ce7dffe8578814b0263714116d9a Mon Sep 17 00:00:00 2001
From: Andrii V <andrii@rhodecode.com>
Date: Mon, 7 Jul 2025 20:53:41 +0200
Subject: [PATCH] tests: fix tests based on feedback

---
 rhodecode/tests/integrations/test_slack.py | 28 ++++++++++++----------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/rhodecode/tests/integrations/test_slack.py b/rhodecode/tests/integrations/test_slack.py
index cd9d76af..04f00987 100644
--- a/rhodecode/tests/integrations/test_slack.py
+++ b/rhodecode/tests/integrations/test_slack.py
@@ -171,7 +171,16 @@ def test_slack_pull_request_branch_info_display(app, base_slack_data):
     assert "`feature/login-improvements` → `main`" in result.text
 
 
-def test_slack_pull_request_different_actions(app, base_slack_data):
+@pytest.mark.parametrize(
+    "expected_class",
+    [
+        events.PullRequestCreateEvent,
+        events.PullRequestUpdateEvent,
+        events.PullRequestMergeEvent,
+        events.PullRequestCloseEvent,
+    ],
+)
+def test_slack_pull_request_different_actions(app, base_slack_data, expected_class):
     handler = SlackDataHandler()
 
     mock_pr = mock.MagicMock()
@@ -181,16 +190,9 @@ def test_slack_pull_request_different_actions(app, base_slack_data):
     slack_data = SlackData(title="default", text="default")
     branch_info = "`bugfix/JIRA-456` → `develop`"
 
-    # Test different PR event types
-    for event_class in [
-        events.PullRequestCreateEvent,
-        events.PullRequestUpdateEvent,
-        events.PullRequestMergeEvent,
-        events.PullRequestCloseEvent,
-    ]:
-        mock_event = mock.MagicMock()
-        mock_event.__class__ = event_class
-        mock_event.pullrequest = mock_pr
+    mock_event = mock.MagicMock()
+    mock_event.__class__ = expected_class
+    mock_event.pullrequest = mock_pr
 
-        result = handler.format_pull_request_event(mock_event, base_slack_data, slack_data)
-        assert branch_info in result.text, f"Branch info missing for {event_class.__name__}"
+    result = handler.format_pull_request_event(mock_event, base_slack_data, slack_data)
+    assert branch_info in result.text, f"Branch info missing for {expected_class.__name__}"