engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pr-model: don't use set to calculate commit ranges as they generate random order.

Browse source
This commit is contained in:
Marcin Kuzminski 2017-01-30 12:41:16 +01:00
parent 2d4747cc69
commit 5e35e36e4f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
rhodecode/model/pull_request.py
View file

@ -630,7 +630,7 @@ class PullRequestModel(BaseModel):
old=pull_request, new=None, changes=None)
# re-compute commit ids
old_commit_ids = set(pull_request.revisions)
old_commit_ids = pull_request.revisions
pre_load = ["author", "branch", "date", "message"]
commit_ranges = target_repo.compare(
target_commit.raw_id, source_commit.raw_id, source_repo, merge=True,
@ -647,7 +647,7 @@ class PullRequestModel(BaseModel):
commit.raw_id for commit in reversed(commit_ranges)]
pull_request.updated_on = datetime.datetime.now()
Session().add(pull_request)
new_commit_ids = set(pull_request.revisions)
new_commit_ids = pull_request.revisions
changes = self._calculate_commit_id_changes(
old_commit_ids, new_commit_ids)