From 5e35e36e4f438fe46060d045a10f93a1dff29bd0 Mon Sep 17 00:00:00 2001 From: Marcin Kuzminski Date: Mon, 30 Jan 2017 12:41:16 +0100 Subject: [PATCH] pr-model: don't use set to calculate commit ranges as they generate random order. --- rhodecode/model/pull_request.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rhodecode/model/pull_request.py b/rhodecode/model/pull_request.py index 1871a1c6..99bbd04a 100644 --- a/rhodecode/model/pull_request.py +++ b/rhodecode/model/pull_request.py @@ -630,7 +630,7 @@ class PullRequestModel(BaseModel): old=pull_request, new=None, changes=None) # re-compute commit ids - old_commit_ids = set(pull_request.revisions) + old_commit_ids = pull_request.revisions pre_load = ["author", "branch", "date", "message"] commit_ranges = target_repo.compare( target_commit.raw_id, source_commit.raw_id, source_repo, merge=True, @@ -647,7 +647,7 @@ class PullRequestModel(BaseModel): commit.raw_id for commit in reversed(commit_ranges)] pull_request.updated_on = datetime.datetime.now() Session().add(pull_request) - new_commit_ids = set(pull_request.revisions) + new_commit_ids = pull_request.revisions changes = self._calculate_commit_id_changes( old_commit_ids, new_commit_ids)