paypal

russellballestrini commented

2025-12-22 14:32:37 -05:00

(Migrated from git2.unturf.com)

Summary by CodeRabbit

New Features
- PayPal and Adyen added as checkout options (saved PayPal methods, disconnect flow, per-shop settings).
- Per-shop masonry toggle for CSS Grid Lanes.
- Play-button overlay on unlocked video thumbnails.
- Enhanced meta tags (Twitter cards) and longer meta descriptions for better link unfurling.
Documentation
- New PayPal and Adyen docs and a project CHANGELOG.
Tests
- Extensive PayPal/Adyen test coverage and sandbox tests added.
Chores
- Database migrations and dependency additions for PayPal/Adyen.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

## Summary by CodeRabbit * **New Features** * PayPal and Adyen added as checkout options (saved PayPal methods, disconnect flow, per-shop settings). * Per-shop masonry toggle for CSS Grid Lanes. * Play-button overlay on unlocked video thumbnails. * Enhanced meta tags (Twitter cards) and longer meta descriptions for better link unfurling. * **Documentation** * New PayPal and Adyen docs and a project CHANGELOG. * **Tests** * Extensive PayPal/Adyen test coverage and sandbox tests added. * **Chores** * Database migrations and dependency additions for PayPal/Adyen. ✏️ Tip: You can customize this high-level summary in your review settings.

russellballestrini commented

2025-12-22 14:32:37 -05:00

(Migrated from git2.unturf.com)

requested review from @russellballestrini

russellballestrini commented

2025-12-22 14:32:37 -05:00

(Migrated from git2.unturf.com)

assigned to @russellballestrini

coderabbitai commented

2025-12-22 14:32:46 -05:00

(Migrated from git2.unturf.com)

Walkthrough

Adds PayPal and Adyen payment integrations: new PayPalUserShop model, Shop and Invoice fields, PayPal checkout and management UI, webhook handlers for PayPal and Stripe, request flags, migrations, SDK dependency, templates, extensive tests, and docs.

Changes

Cohort / File(s)	Change Summary
Documentation `CHANGELOG.rst`, `README.rst`, `docs/PAYPAL.md`, `docs/ADYEN.md`	Adds CHANGELOG entry (2025-12-22) describing PayPal integration, grid/thumbnail/meta updates; updates README payment methods; adds detailed PayPal and Adyen docs.
Configuration `development.ini`, `test.ini`	Adds PayPal config keys (`app.paypal.sandbox_mode`, `app.paypal.webhook_id`, `app.payments.paypal.enabled`) and enables PayPal sandbox in tests.
Models & Meta `make_post_sell/models/__init__.py`, `make_post_sell/models/meta.py`, `make_post_sell/models/paypal_user_shop.py`, `make_post_sell/models/shop.py`, `make_post_sell/models/invoice.py`	New `PayPalUserShop` model and export; CLASS_TO_TABLE mapping updated. `Shop` gains PayPal and Adyen credential fields, enabled flags, readiness properties, SDK accessors, and `paypal_user_shop(user)`. `Invoice` gains PayPal/Stripe/Adyen tracking columns, payment_method resolution, and lookup helpers.
Request Methods `make_post_sell/request_methods.py`	Adds reified request methods: `paypal_enabled`, `paypal_globally_enabled`, `adyen_enabled`, `adyen_globally_enabled`.
Routes `make_post_sell/routes.py`	Registers new routes: `/billing/disconnect-paypal`, `/paypal/create-order/{cart_id}`, `/paypal/complete-checkout/{cart_id}`, `/adyen/create-session/{cart_id}`, `/adyen/complete-checkout/{cart_id}`, and webhook endpoints for PayPal/Stripe/Adyen.
Templates `make_post_sell/templates/billing.j2`, `make_post_sell/templates/cart_checkout.j2`, `make_post_sell/templates/shop_settings.j2`	Adds PayPal saved-method UI and disconnect form to billing; integrates PayPal SDK/button, vaulting, multi-shop order handling and CSRF-safe submit in cart checkout; adds PayPal and Adyen settings blocks (with JS toggles) to shop settings.
Views `make_post_sell/views/billing.py`, `make_post_sell/views/cart.py`, `make_post_sell/views/webhooks.py`, `make_post_sell/views/shop.py`	Billing view exposes `paypal_user_shop` and implements `disconnect_paypal`. Cart view adds `paypal_create_order` and `paypal_complete_checkout` flows. New `webhooks.py` implements PayPal and Stripe webhook handlers with verification, idempotency, invoice updates, unlocks, and email dispatch. Shop view handles Adyen settings form.
Database Migrations `make_post_sell/scripts/alembic/versions/418933067d81_add_paypal_credentials_to_shop.py`, `.../3734955e7379_add_adyen_payment_columns_to_shop_and_.py`, `.../63d935094f97_add_stripe_payment_tracking_columns_to_.py`	Migrations add/remove PayPal columns on `mps_shop` and `mps_invoice`, add Adyen columns on `mps_shop` and `mps_invoice`, and add Stripe tracking columns on `mps_invoice`.
Dependencies `requirements.py3.txt`	Adds `paypalrestsdk` dependency.
Tests `make_post_sell/tests/test_functional.py`, `make_post_sell/tests/test_integration.py`, `make_post_sell/tests/test_models.py`	Adds numerous PayPal-focused unit, functional, and integration tests (credential persistence, endpoints, sandbox API flows, PayPalUserShop constraints, invoice linkage). Some duplicated tests found in integration suite; updates existing checkout expectations.
UI Notes `CHANGELOG.rst`	Documents CSS Grid Lanes toggle, video thumbnail overlay styling, and extended meta description length.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client / Browser
    participant Server as App Server
    participant PayPal as PayPal API
    participant DB as Database

    Client->>Server: POST /paypal/create-order/{cart_id}
    activate Server
    Server->>DB: Fetch cart & shop items
    Server->>PayPal: Create order(s) per-shop via SDK
    PayPal-->>Server: Respond with order ID(s)
    Server-->>Client: JSON {order_id, order_ids}
    deactivate Server

    Client->>PayPal: User approves payment (PayPal UI)
    PayPal-->>Client: Approval token/response

    Client->>Server: POST /paypal/complete-checkout/{cart_id} (order IDs)
    activate Server
    Server->>PayPal: Capture order(s)
    PayPal-->>Server: Capture responses
    Server->>DB: Create/update Invoice(s), set paypal_order_id/paypal_capture_id, handle vaulting
    Server-->>Client: Redirect (success/failure)
    deactivate Server

sequenceDiagram
    participant PayPal as PayPal (Event Source)
    participant Server as Webhook Handler
    participant DB as Database
    participant Email as Email Service

    PayPal->>Server: POST /webhooks/paypal (event)
    activate Server
    Server->>Server: Verify signature
    Server->>DB: Lookup Invoice by paypal_order_id
    alt Invoice found and not processed
        Server->>DB: Update invoice (set capture id, mark paid)
        Server->>DB: Unlock user products
        Server->>Email: Send purchase/sale emails
        Server-->>PayPal: 200 OK
    else Invoice missing or already processed
        Server-->>PayPal: 200 OK (no retry)
    end
    deactivate Server

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between a2e2092a31 and 4210bc1421.

📒 Files selected for processing (13)

docs/ADYEN.md
make_post_sell/models/invoice.py
make_post_sell/models/shop.py
make_post_sell/request_methods.py
make_post_sell/routes.py
make_post_sell/scripts/alembic/versions/3734955e7379_add_adyen_payment_columns_to_shop_and_.py
make_post_sell/templates/shop_settings.j2
make_post_sell/tests/test_functional.py
make_post_sell/tests/test_integration.py
make_post_sell/tests/test_models.py
make_post_sell/views/cart.py
make_post_sell/views/shop.py
make_post_sell/views/webhooks.py

🚧 Files skipped from review as they are similar to previous changes (1)

make_post_sell/models/invoice.py

📝 NOTE

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

## Walkthrough Adds PayPal and Adyen payment integrations: new PayPalUserShop model, Shop and Invoice fields, PayPal checkout and management UI, webhook handlers for PayPal and Stripe, request flags, migrations, SDK dependency, templates, extensive tests, and docs. ## Changes | Cohort / File(s) | Change Summary | |---|---| | **Documentation** `CHANGELOG.rst`, `README.rst`, `docs/PAYPAL.md`, `docs/ADYEN.md` | Adds CHANGELOG entry (2025-12-22) describing PayPal integration, grid/thumbnail/meta updates; updates README payment methods; adds detailed PayPal and Adyen docs. | | **Configuration** `development.ini`, `test.ini` | Adds PayPal config keys (`app.paypal.sandbox_mode`, `app.paypal.webhook_id`, `app.payments.paypal.enabled`) and enables PayPal sandbox in tests. | | **Models & Meta** `make_post_sell/models/__init__.py`, `make_post_sell/models/meta.py`, `make_post_sell/models/paypal_user_shop.py`, `make_post_sell/models/shop.py`, `make_post_sell/models/invoice.py` | New `PayPalUserShop` model and export; CLASS_TO_TABLE mapping updated. `Shop` gains PayPal and Adyen credential fields, enabled flags, readiness properties, SDK accessors, and `paypal_user_shop(user)`. `Invoice` gains PayPal/Stripe/Adyen tracking columns, payment_method resolution, and lookup helpers. | | **Request Methods** `make_post_sell/request_methods.py` | Adds reified request methods: `paypal_enabled`, `paypal_globally_enabled`, `adyen_enabled`, `adyen_globally_enabled`. | | **Routes** `make_post_sell/routes.py` | Registers new routes: `/billing/disconnect-paypal`, `/paypal/create-order/{cart_id}`, `/paypal/complete-checkout/{cart_id}`, `/adyen/create-session/{cart_id}`, `/adyen/complete-checkout/{cart_id}`, and webhook endpoints for PayPal/Stripe/Adyen. | | **Templates** `make_post_sell/templates/billing.j2`, `make_post_sell/templates/cart_checkout.j2`, `make_post_sell/templates/shop_settings.j2` | Adds PayPal saved-method UI and disconnect form to billing; integrates PayPal SDK/button, vaulting, multi-shop order handling and CSRF-safe submit in cart checkout; adds PayPal and Adyen settings blocks (with JS toggles) to shop settings. | | **Views** `make_post_sell/views/billing.py`, `make_post_sell/views/cart.py`, `make_post_sell/views/webhooks.py`, `make_post_sell/views/shop.py` | Billing view exposes `paypal_user_shop` and implements `disconnect_paypal`. Cart view adds `paypal_create_order` and `paypal_complete_checkout` flows. New `webhooks.py` implements PayPal and Stripe webhook handlers with verification, idempotency, invoice updates, unlocks, and email dispatch. Shop view handles Adyen settings form. | | **Database Migrations** `make_post_sell/scripts/alembic/versions/418933067d81_add_paypal_credentials_to_shop.py`, `.../3734955e7379_add_adyen_payment_columns_to_shop_and_.py`, `.../63d935094f97_add_stripe_payment_tracking_columns_to_.py` | Migrations add/remove PayPal columns on `mps_shop` and `mps_invoice`, add Adyen columns on `mps_shop` and `mps_invoice`, and add Stripe tracking columns on `mps_invoice`. | | **Dependencies** `requirements.py3.txt` | Adds `paypalrestsdk` dependency. | | **Tests** `make_post_sell/tests/test_functional.py`, `make_post_sell/tests/test_integration.py`, `make_post_sell/tests/test_models.py` | Adds numerous PayPal-focused unit, functional, and integration tests (credential persistence, endpoints, sandbox API flows, PayPalUserShop constraints, invoice linkage). Some duplicated tests found in integration suite; updates existing checkout expectations. | | **UI Notes** `CHANGELOG.rst` | Documents CSS Grid Lanes toggle, video thumbnail overlay styling, and extended meta description length. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Client as Client / Browser participant Server as App Server participant PayPal as PayPal API participant DB as Database Client->>Server: POST /paypal/create-order/{cart_id} activate Server Server->>DB: Fetch cart & shop items Server->>PayPal: Create order(s) per-shop via SDK PayPal-->>Server: Respond with order ID(s) Server-->>Client: JSON {order_id, order_ids} deactivate Server Client->>PayPal: User approves payment (PayPal UI) PayPal-->>Client: Approval token/response Client->>Server: POST /paypal/complete-checkout/{cart_id} (order IDs) activate Server Server->>PayPal: Capture order(s) PayPal-->>Server: Capture responses Server->>DB: Create/update Invoice(s), set paypal_order_id/paypal_capture_id, handle vaulting Server-->>Client: Redirect (success/failure) deactivate Server ``` ```mermaid sequenceDiagram participant PayPal as PayPal (Event Source) participant Server as Webhook Handler participant DB as Database participant Email as Email Service PayPal->>Server: POST /webhooks/paypal (event) activate Server Server->>Server: Verify signature Server->>DB: Lookup Invoice by paypal_order_id alt Invoice found and not processed Server->>DB: Update invoice (set capture id, mark paid) Server->>DB: Unlock user products Server->>Email: Send purchase/sale emails Server-->>PayPal: 200 OK else Invoice missing or already processed Server-->>PayPal: 200 OK (no retry) end deactivate Server ``` ## Estimated code review effort 🎯 4 (Complex) | ⏱️ ~60 minutes  --- <details> <summary>📜 Recent review details</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Free <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between a2e2092a31f905f362d8bfbac2fc76c83153f500 and 4210bc1421471fd994c65505f69949b3f11db225. </details> <details> <summary>📒 Files selected for processing (13)</summary> * `docs/ADYEN.md` * `make_post_sell/models/invoice.py` * `make_post_sell/models/shop.py` * `make_post_sell/request_methods.py` * `make_post_sell/routes.py` * `make_post_sell/scripts/alembic/versions/3734955e7379_add_adyen_payment_columns_to_shop_and_.py` * `make_post_sell/templates/shop_settings.j2` * `make_post_sell/tests/test_functional.py` * `make_post_sell/tests/test_integration.py` * `make_post_sell/tests/test_models.py` * `make_post_sell/views/cart.py` * `make_post_sell/views/shop.py` * `make_post_sell/views/webhooks.py` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * make_post_sell/models/invoice.py </details> </details>  --- > 📝 **NOTE** > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.

coderabbitai commented

2025-12-22 14:33:30 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 15:21:49 -05:00

(Migrated from git2.unturf.com)

added 1 commit

31592b69 - Add PayPal unit, integration, and sandbox functional tests

Compare with previous version

added 1 commit <ul><li>31592b69 - Add PayPal unit, integration, and sandbox functional tests</li></ul> [Compare with previous version](/engineering/make-post-sell/make_post_sell/-/merge_requests/57/diffs?diff_id=912&start_sha=979c5117df7ff4f351511921b2f8f7f4592a67aa)

coderabbitai commented

2025-12-22 15:22:44 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 15:33:06 -05:00

(Migrated from git2.unturf.com)

added 1 commit

0b89ab2b - Fix test_cart_checkout_for_shop to match current checkout flow

Compare with previous version

added 1 commit <ul><li>0b89ab2b - Fix test_cart_checkout_for_shop to match current checkout flow</li></ul> [Compare with previous version](/engineering/make-post-sell/make_post_sell/-/merge_requests/57/diffs?diff_id=914&start_sha=31592b69239d8adf2b6636ba3f9399ba8c3f14f5)

coderabbitai commented

2025-12-22 15:33:45 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 16:03:48 -05:00

(Migrated from git2.unturf.com)

added 1 commit

ac2f5864 - Add Stripe payment tracking and webhook resilience

Compare with previous version

added 1 commit <ul><li>ac2f5864 - Add Stripe payment tracking and webhook resilience</li></ul> [Compare with previous version](/engineering/make-post-sell/make_post_sell/-/merge_requests/57/diffs?diff_id=916&start_sha=0b89ab2bb3833ef67309bcace4751aca816a5fe8)

coderabbitai commented

2025-12-22 16:04:42 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 16:12:06 -05:00

(Migrated from git2.unturf.com)

added 1 commit

a2e2092a - Add privacy warnings to PayPal docs, create Adyen integration doc

Compare with previous version

added 1 commit <ul><li>a2e2092a - Add privacy warnings to PayPal docs, create Adyen integration doc</li></ul> [Compare with previous version](/engineering/make-post-sell/make_post_sell/-/merge_requests/57/diffs?diff_id=918&start_sha=ac2f58645366a6e3511513e5b18dc7a39ad116e1)

coderabbitai commented

2025-12-22 16:12:46 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 17:17:04 -05:00

(Migrated from git2.unturf.com)

added 1 commit

4210bc14 - Add Adyen payment integration

Compare with previous version

added 1 commit <ul><li>4210bc14 - Add Adyen payment integration</li></ul> [Compare with previous version](/engineering/make-post-sell/make_post_sell/-/merge_requests/57/diffs?diff_id=920&start_sha=a2e2092a31f905f362d8bfbac2fc76c83153f500)

coderabbitai commented

2025-12-22 17:17:50 -05:00

(Migrated from git2.unturf.com)

changed the description

russellballestrini commented

2025-12-22 17:29:52 -05:00

(Migrated from git2.unturf.com)

mentioned in commit fe0482ac8a

mentioned in commit fe0482ac8a276e8f2590e462dd9705f62c03a429

russellballestrini (Migrated from git2.unturf.com) merged commit fe0482ac8a into master

2025-12-22 17:29:52 -05:00

Rows
Columns

paypal #93

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort