Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
1.6 KiB
gradle-0001 — OptionReader: CollectionUtils.toList(optionNames).contains() rebuilt per method
Target
gradle/gradle — subprojects/core/src/main/java/org/gradle/api/internal/tasks/options/OptionReader.java
CWE
CWE-407: Algorithmic Complexity — O(n) linear membership inside a hot loop
Location
OptionReader.java:94-96
for (JavaMethod<Object, ?> optionValueMethod : optionValueMethods) {
String[] optionNames = getOptionNames(optionValueMethod);
if (CollectionUtils.toList(optionNames).contains(optionElement.getOptionName())) {
Description
getOptionValueMethodForOption() iterates over all @OptionValues-annotated methods in a task
class. For each method, it calls CollectionUtils.toList(optionNames) — converting a String[] to
a new ArrayList — then calls .contains() on it, performing a linear scan.
This runs during task option resolution: once per (OptionElement, task class) pair. For a task
with A option elements and M value-methods each with N option names, complexity is O(A × M × N).
The optionNames array is sourced from @OptionValues(value = {...}) annotation data and is
effectively a constant per method — a perfect candidate for a precomputed HashSet.
Complexity
- Slow path: O(A × M × N) — new ArrayList per inner-loop iteration
- Fast path: O(A × M) with
Arrays.asList(optionNames)→HashSetor direct array membership check
Patch
defects/gradle/patch/gradle-0001-option-reader-set-membership.patch
Unit Test
defects/gradle/unit/GradleOptionReaderTest.java
Status
PATCHED