russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
1.6 KiB
storm-0001: Fields constructor duplicate check — List.contains() O(n²)
Target: Apache Storm
File: storm-client/src/jvm/org/apache/storm/tuple/Fields.java
CWE: CWE-407 — Inefficient Algorithmic Complexity
Severity: MEDIUM
Status: PATCHED
Description
The Fields(List<String>) constructor checks for duplicate field names using
this.fields.contains(field) where fields is an ArrayList<String>. The loop
over n fields each calls contains() on a growing ArrayList — worst-case O(n²)
for a fully-unique field list.
// storm-client/.../tuple/Fields.java line 35-44
private List<String> fields; // ArrayList<String>
private Map<String, Integer> index = new HashMap<>();
public Fields(List<String> fields) {
this.fields = new ArrayList<>(fields.size());
for (String field : fields) {
if (this.fields.contains(field)) { // O(n) per iteration → O(n²) total
throw new IllegalArgumentException(
String.format("duplicate field '%s'", field));
}
this.fields.add(field);
}
index(); // builds the HashMap index AFTER the loop
}
index is built after construction. The fix is to use index (which is populated
incrementally) for the duplicate check, converting the O(n²) constructor to O(n).
Fix
Check index.containsKey(field) instead of this.fields.contains(field) and add to
index inline. The existing index() call at the end becomes a no-op or is removed.
Patch
defects/storm/patch/storm-0001.patch
Unit Test
defects/storm/unit/StormFieldsDedupTest.java