russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
1.5 KiB
nats-0001 — jetstream_cluster: O(n²) slices.Contains in peer-set dedup loop
Target: nats-io/nats-server
File: server/jetstream_cluster.go
Function: stream update/move handler (jsStreamUpdateRequest path)
Severity: MEDIUM
CWE: CWE-407 (Algorithmic Complexity — Quadratic Membership Test)
Status: PATCHED
Defect
During a JetStream stream move operation, existing peers are deduplicated against a new peer group using a nested scan:
// filter peers present in both sets
for _, peer := range rg.Peers {
if !slices.Contains(nrg.Peers, peer) {
peerSet = append(peerSet, peer)
}
}
peerSet = append(peerSet, nrg.Peers...)
rg.Peers and nrg.Peers are []string slices. slices.Contains is O(|nrg.Peers|).
The outer loop runs O(|rg.Peers|) times. Total: O(|rg.Peers| × |nrg.Peers|).
In a large JetStream cluster (hundreds of streams, many replicas), this is called once per stream move/scale operation and degrades quadratically with replica count and peer count.
Fix
Build a set from nrg.Peers before the loop:
// filter peers present in both sets
nrgPeerSet := make(map[string]struct{}, len(nrg.Peers))
for _, p := range nrg.Peers {
nrgPeerSet[p] = struct{}{}
}
for _, peer := range rg.Peers {
if _, ok := nrgPeerSet[peer]; !ok {
peerSet = append(peerSet, peer)
}
}
peerSet = append(peerSet, nrg.Peers...)
Patch
defects/nats-server/patch/nats-0001-peer-dedup-map.patch
Unit Test
defects/nats-server/unit/NatsPeerDedupTest.java