java-topology/defects/diesel/patch/diesel-diamond-recursion-CLEAN.md
russell@unturf.com 3986d8dc50 diamond hunt: godot-0009/0010 + meson-0002 + typeorm-0004/0005 + ts-0003; count 629→635
New diamond recursion defects (O(2^D) → O(N)):
- godot-0009: Font::_is_cyclic no visited set — CJK fallback diamond, 2648x at F=4,D=8
- godot-0010: Font::_update_rids_fb no visited set — duplicate RIDs + O(N^2) hot path
- meson-0002: get_internal_static_libraries_recurse link_whole guard missing — 132x at D=10
- typescript-0003: hasBaseType inner check() no visited set — 1024x at D=10; hot on instanceof

New O(N²) defects:
- typeorm-0004: SubjectTopologicalSorter Array.indexOf dedup — 200x at N=400
- typeorm-0005: DepGraph.createDFS result.indexOf + addDependency edge dedup — 300x at N=600

CLEAN confirmed (diamond recursion sweep): bazel, cargo, cmake, composer, dgl, diesel,
doctrine-orm, efcore, helm, mybatis, networkx-deeper, ninja, npm-arborist, peewee, pip,
rubygems, seaorm, sqlalchemy, swift

UNDF: 571→578 assigned; MOAD count: 629→635
2026-03-29 16:52:04 -04:00

17 lines
737 B
Markdown

# diesel diamond recursion scan — CLEAN
Scanned: 2026-03-29
Scope: diamond recursion / CWE-407 in schema/migration dependency traversal
## Files checked
- `diesel/src/` — Diesel is a query builder / schema-definition library.
There is no runtime migration dependency graph or table ordering code in the
main crate. Schema ordering is handled at compile time via Rust's type system.
- `diesel/src/query_dsl/`, `diesel/src/query_builder/` — query ordering DSL
(`order`, `then_order_by`) is SQL ORDER BY clause construction, not graph topology.
## Verdict
CLEAN. Diesel has no runtime graph traversal for dependency ordering. Diesel already
has 3 previous defects (0001-0003) in SQLite/MySQL row column HashMap conversion.