russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
1.8 KiB
grafana-0001: dfs() visited-array Array.includes — O(n²) on time-range refresh
Target: Grafana (public/app/features/variables)
File: public/app/features/variables/state/actions.ts
CWE: CWE-407 — Inefficient Algorithmic Complexity
Severity: MEDIUM
Status: PATCHED
Description
dfs() and getVariablesThatNeedRefreshNew() track visited graph nodes using a
plain string[] array (visitedDfs). Each visit check calls visited.includes(node.name)
which is O(V) where V = visited count. The outer allVariables.forEach iterates N
variables, and inside dfs() every outputEdges.forEach call also performs
!visited.includes(child.name) — making the total cost O(N²) in the number of
dashboard variables.
This code runs on every time-range change event for every dashboard that uses
query variables with onTimeRangeChanged refresh. Dashboards with 50+ variables
(common in large Grafana deployments) experience quadratic work per time-range
update.
// actions.ts line 666-671
const dfs = (node, visited: string[], variables, variablesRefreshTimeRange) => {
if (!visited.includes(node.name)) { // O(V) — called O(N) times → O(N²)
visited.push(node.name);
}
node.outputEdges.forEach((e) => {
if (child && !visited.includes(child.name)) { // another O(V) per edge
And the outer loop (line 728):
if (visitedDfs.includes(v.name)) { // O(V) inside forEach over allVariables → O(N²)
Fix
Replace visited: string[] with visited: Set<string>. All .includes() calls
become .has() — O(1). .push() becomes .add(). Total DFS cost drops to O(N + E)
where E = number of variable dependency edges.
Patch
defects/grafana/patch/grafana-0001.patch
Unit Test
defects/grafana/unit/GrafanaTest.java