java-topology/tools/tickets/scans/opendaylight-mdsal.md at 176d9f88de0241739cdf0a8fa29e9c16f8eb5708

russell@unturf.com db29a08762 undefect. CWE-407 — 92 sites, 42 ecosystems

B&W print-friendly diagrams + tinkerpop-0001 + wave-3 proof sections.
Squash of 94 local commits onto remote master.

2026-03-26 19:48:18 -04:00

2.2 KiB

Raw Blame History

id	priority	status	created
scan-opendaylight-mdsal	high	unscanned	2026-03-23

Target

Repo: https://github.com/opendaylight/mdsal Language: Java Why: Telco MPLS-TE path computation runs on OpenDaylight in production carrier networks — linear membership scans in the graph API inflate path setup latency under load.

Scan command

# Shallow clone
git clone --depth 1 https://github.com/opendaylight/mdsal /tmp/opendaylight-mdsal

# Submit to unsandbox
cat > /tmp/scan-opendaylight-mdsal.sh << 'EOF'
#!/usr/bin/env bash
set -euo pipefail
GRAPH_KW="tarjan|strongly.connected|dfs|scc|topolog|topo.sort|cycle|reachab|postorder|dominator|liveness|digraph|shortest.path|path.find"
MEM="\.contains\(|ArrayList.*contains|List.*contains|visited\.contains|path\.contains|stack\.contains"
find /tmp/opendaylight-mdsal -name "*.java" | sort | while read f; do
  graph_lines=$(grep -inE "$GRAPH_KW" "$f" 2>/dev/null | cut -d: -f1 | head -5 || true)
  [ -z "$graph_lines" ] && continue
  while IFS= read -r lineno; do
    s=$(( lineno > 20 ? lineno - 20 : 1 )); e=$(( lineno + 20 ))
    hit=$(sed -n "${s},${e}p" "$f" 2>/dev/null | grep -iE "$MEM" | head -1 | sed 's/^\s*//' || true)
    [ -n "$hit" ] && echo "CANDIDATE\t${f}:${lineno}\t${hit}"
  done <<< "$graph_lines"
done
EOF
export UNSANDBOX_PUBLIC_KEY=unsb-pk-russ-test-isth-best
export UNSANDBOX_SECRET_KEY=unsb-sk-rk46c-3zvpg-zjf6z-hjrge
~/git/un-inception/build/un /tmp/scan-opendaylight-mdsal.sh

Key files to check

Topology service interfaces and implementations under any topology package
Graph API classes — look for Graph, Vertex, Edge implementations
Path computation modules — any class named PathComputation, ShortestPath, or similar

Expected pattern

.contains( called on a List or ArrayList typed as visited/seen/path inside a graph traversal method in the topology or graph API package, where a HashSet or LinkedHashSet would provide O(1) membership.

Acceptance criteria

Scan run and results saved to tools/scan-results/opendaylight-mdsal.txt
All CANDIDATE hits triaged (confirmed defect or false positive)
If confirmed: defect ticket created in tools/tickets/defects/

2.2 KiB Raw Blame History