java-topology/defects/neo4j/patch/neo4j-diamond-recursion-CLEAN.md
russell@unturf.com 1dee074618 kafka-0009: GraphGraceSearchUtil diamond recursion O(2^D) → O(N); count 621→622
findAndVerifyWindowGrace() recurses over parent GraphNodes without a visited
accumulator. Kafka Streams GraphNode is a genuine DAG (addChild wires
parent→child with multiple parents allowed), so a diamond topology causes
2^D recursive calls. Fix: thread an IdentityHashMap<GraphNode,Long> memo
through recursion; memoize on first visit, return cached result on revisit.
8/8 unit tests PASS; D=10 defect count=3071 vs patched O(N).

Diamond-recursion CLEAN markers added for: flink, neo4j, janusgraph,
tinkerpop, dgraph, zookeeper, storm, ant, gradle, graal, eclipse-jdt,
exposed, intellij, kotlin, scala3, hibernate-0007 (prior session work
now committed).
2026-03-29 16:59:50 -04:00

485 B

neo4j — diamond recursion CWE-407 scan: CLEAN

Scan date: 2026-03-29

Method scanned

graph-algo package: ShortestPath, Dijkstra, SingleSourceShortestPath* — all use explicit frontier/visited sets (BFS/Dijkstra state maps).

Kernel schema/type hierarchy: no recursive parent-traversal methods found. Java class hierarchy traversal uses Class.getSuperclass() which is bounded by the Java class hierarchy depth (tree, not DAG at the Java level).

Verdict: CLEAN