java-topology/tools/tickets/scans/onos.md at master

russell@unturf.com db29a08762 undefect. CWE-407 — 92 sites, 42 ecosystems

B&W print-friendly diagrams + tinkerpop-0001 + wave-3 proof sections.
Squash of 94 local commits onto remote master.

2026-03-26 19:48:18 -04:00

2.2 KiB

Raw Permalink Blame History

id	priority	status	created
scan-onos	high	unscanned	2026-03-23

Target

Repo: https://github.com/opennetworkinglab/onos Language: Java Why: AT&T, NTT, and Comcast production SDN controller — linear-scan path membership in topology service directly impacts network-wide re-routing latency.

Scan command

# Shallow clone
git clone --depth 1 https://github.com/opennetworkinglab/onos /tmp/onos

# Submit to unsandbox
cat > /tmp/scan-onos.sh << 'EOF'
#!/usr/bin/env bash
set -euo pipefail
GRAPH_KW="tarjan|strongly.connected|dfs|scc|topolog|topo.sort|cycle|reachab|postorder|dominator|liveness|digraph|shortest.path|path.find"
MEM="\.contains\(|ArrayList.*contains|List.*contains|visited\.contains|path\.contains|stack\.contains"
find /tmp/onos/core -name "*.java" | sort | while read f; do
  graph_lines=$(grep -inE "$GRAPH_KW" "$f" 2>/dev/null | cut -d: -f1 | head -5 || true)
  [ -z "$graph_lines" ] && continue
  while IFS= read -r lineno; do
    s=$(( lineno > 20 ? lineno - 20 : 1 )); e=$(( lineno + 20 ))
    hit=$(sed -n "${s},${e}p" "$f" 2>/dev/null | grep -iE "$MEM" | head -1 | sed 's/^\s*//' || true)
    [ -n "$hit" ] && echo "CANDIDATE\t${f}:${lineno}\t${hit}"
  done <<< "$graph_lines"
done
EOF
export UNSANDBOX_PUBLIC_KEY=unsb-pk-russ-test-isth-best
export UNSANDBOX_SECRET_KEY=unsb-sk-rk46c-3zvpg-zjf6z-hjrge
~/git/un-inception/build/un /tmp/scan-onos.sh

Key files to check

core/api/src/main/java/org/onosproject/net/topology/ — Topology service API; path/vertex abstractions
core/net/src/main/java/org/onosproject/net/topology/ — Default topology implementation; graph algorithms
core/api/src/main/java/org/onosproject/net/graph/ — Graph data structure; adjacency and traversal

Expected pattern

visited.contains(vertex) or path.contains(link) where visited or path is an ArrayList (not a HashSet) inside a Dijkstra or DFS topology computation method, producing O(V) membership cost per node relaxation.

Acceptance criteria

Scan run and results saved to tools/scan-results/onos.txt
All CANDIDATE hits triaged (confirmed defect or false positive)
If confirmed: defect ticket created in tools/tickets/defects/

2.2 KiB Raw Permalink Blame History