russell@unturf.com 9934133dcf whitepaper: 312 sites / 151 ecosystems — wave2+3 defect tables and PDF rebuild

Add 88 new defect entries to HIGH and MEDIUM tables:
  HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
        vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
        tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
        allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
        mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
        linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
        perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002

  MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
          cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
          pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
          ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
          r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
          ovs-0001, onos-0003, odl-0002, jetty-0001

PDF: 976K

2026-03-27 15:23:43 -04:00

1.7 KiB

Raw Permalink Blame History

sdl2-0001 — SDL_GetJoystickFromID / SDL_GetGamepadFromID O(n) linked-list walk

Status

PATCHED

Severity

MEDIUM

Target

SDL src/joystick/SDL_joystick.c, src/joystick/SDL_gamepad.c

CWE

CWE-407: Algorithmic Complexity — Insufficient Complexity Reduction Before Algorithmic Intensive Operation

Description

SDL_GetJoystickFromID(SDL_JoystickID instance_id) and SDL_GetGamepadFromID(SDL_JoystickID joyid) both perform O(n) linked-list walks to find a joystick/gamepad by its instance ID.

// SDL_joystick.c:1960
SDL_Joystick *SDL_GetJoystickFromID(SDL_JoystickID instance_id)
{
    SDL_LockJoysticks();
    for (joystick = SDL_joysticks; joystick; joystick = joystick->next) {  // O(n)
        if (joystick->instance_id == instance_id) break;
    }
    SDL_UnlockJoysticks();
    return joystick;
}

// SDL_gamepad.c:4160
SDL_Gamepad *SDL_GetGamepadFromID(SDL_JoystickID joyid)
{
    while (gamepad) {  // O(n)
        if (gamepad->joystick->instance_id == joyid) ...
        gamepad = gamepad->next;
    }
}

These functions are called 41+ times across src/joystick/ including per-packet HIDAPI device update loops (SDL_hidapijoystick.c:652, :808, :873), per-device-num-joysticks inner loops, and device property update paths. With N open joysticks, each call is O(N).

Fix

Add a SDL_HashTable (SDL already has SDL_hashtable.h) mapping SDL_JoystickID → SDL_Joystick* and SDL_JoystickID → SDL_Gamepad*. Insert on open, remove on close. Lookup becomes O(1).

Complexity

Before: O(n) per lookup where n = number of open joysticks
After: O(1) with hash table

Files

defects/sdl2/patch/sdl2-0001.patch
defects/sdl2/unit/Sdl2JoystickLookupTest.java

1.7 KiB Raw Permalink Blame History