russell@unturf.com 9934133dcf whitepaper: 312 sites / 151 ecosystems — wave2+3 defect tables and PDF rebuild

Add 88 new defect entries to HIGH and MEDIUM tables:
  HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
        vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
        tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
        allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
        mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
        linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
        perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002

  MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
          cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
          pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
          ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
          r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
          ovs-0001, onos-0003, odl-0002, jetty-0001

PDF: 976K

2026-03-27 15:23:43 -04:00

1.4 KiB

Raw Permalink Blame History

onos-0003: DeviceManager RoleInfo.backups() ImmutableList.contains() — O(n) per role event

Status

PATCHED

Target

opennetworkinglab/onos

File

core/api/src/main/java/org/onosproject/cluster/RoleInfo.java core/net/src/main/java/org/onosproject/net/device/impl/DeviceManager.java

Symptom

On every mastership role change event, DeviceManager checks whether localNodeId is in the backup list using List.contains() on an ImmutableList. With C ONOS cluster nodes, the backup list has up to C-1 entries. In large clusters (10–50 nodes) this is O(C) per device event. With D managed devices, each failover triggers D events — O(D×C) total.

Root cause

// RoleInfo.java:32,36
private final List<NodeId> backups;
this.backups = ImmutableList.copyOf(backups);   // O(n) contains

// DeviceManager.java:1159
} else if (event.roleInfo().backups().contains(localNodeId)) {

backups() returns ImmutableList<NodeId> — linear scan backed by an array.

Fix

Change backups to ImmutableSet<NodeId>. Order of backup list is not meaningful for membership tests; ImmutableSet.contains() is O(1) hash lookup.

Complexity

Before	After
O(C) per role event	O(1) per role event

Patch

defects/onos/patch/onos-0003-roleinfo-backups-immutablelist-linear.patch

Unit test

defects/onos/unit/OnosRoleInfoTest.java

1.4 KiB Raw Permalink Blame History Unescape Escape