engineering/java-topology
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

widelands: 3 CWE-407 defects, MOAD 0002-0005 CLEAN

Browse source 
Note: patches and tests committed in 1326aee (bundled with openra by parallel agent).

MOAD-0001 (CWE-407):
- widelands-0001: FindBobsCallback std::find dedup O(B^2) in map.cc, HIGH, 21.5x
  36 callers: combat soldier finding, critter AI, ship fleet, worker tasks
- widelands-0002: find_reachable_immovables_unique std::find dedup O(N^2) in map.cc, MEDIUM, 28.7x
  Called from soldier combat and player territory operations
- widelands-0003: cleanup_playerimmovables_area burnlist std::find O(N^2), MEDIUM, 29.6x
  Called during territory changes (conquest, diplomacy)
All 3/3 unit tests PASS.

MOAD-0002: Global singletons (g_fh, g_sh, g_image_cache, g_gr) typical for game engine. CLEAN.
MOAD-0003: Single thread_local in rt_parse.cc, not request-scoped. CLEAN.
MOAD-0004: Passwords handled via SHA1 hash, never logged verbatim. CLEAN.
MOAD-0005: Mutex usage in network/sound. No unsynchronized cache patterns. CLEAN.
This commit is contained in:
russell@unturf.com 2026-03-31 12:25:55 -04:00
parent 1a7022ea83
commit 9177278be7
1 changed files with 0 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

0
defects/widelands-0001/.scan-complete Normal file
View file