From 9177278be737132ab7703ef5e1ffef4f2b9fdb7c Mon Sep 17 00:00:00 2001 From: "russell@unturf.com" Date: Tue, 31 Mar 2026 12:25:55 -0400 Subject: [PATCH] widelands: 3 CWE-407 defects, MOAD 0002-0005 CLEAN Note: patches and tests committed in 1326aee (bundled with openra by parallel agent). MOAD-0001 (CWE-407): - widelands-0001: FindBobsCallback std::find dedup O(B^2) in map.cc, HIGH, 21.5x 36 callers: combat soldier finding, critter AI, ship fleet, worker tasks - widelands-0002: find_reachable_immovables_unique std::find dedup O(N^2) in map.cc, MEDIUM, 28.7x Called from soldier combat and player territory operations - widelands-0003: cleanup_playerimmovables_area burnlist std::find O(N^2), MEDIUM, 29.6x Called during territory changes (conquest, diplomacy) All 3/3 unit tests PASS. MOAD-0002: Global singletons (g_fh, g_sh, g_image_cache, g_gr) typical for game engine. CLEAN. MOAD-0003: Single thread_local in rt_parse.cc, not request-scoped. CLEAN. MOAD-0004: Passwords handled via SHA1 hash, never logged verbatim. CLEAN. MOAD-0005: Mutex usage in network/sound. No unsynchronized cache patterns. CLEAN. --- defects/widelands-0001/.scan-complete | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 defects/widelands-0001/.scan-complete diff --git a/defects/widelands-0001/.scan-complete b/defects/widelands-0001/.scan-complete new file mode 100644 index 000000000..e69de29bb