nestopia: all 5 MOADs CLEAN

MOAD-0001 (CWE-407): Nestopia uses std::lower_bound (binary search, sorted
array) for cheat code lookup in NstCheats.cpp -- already O(log N). Input
mapping in fltkui/inputmanager.cpp uses hash maps (jbmap/jhmap/jamap keyed
by port*100+inum) -- O(1). No linear scan inside any hot loop found.

MOAD-0002: Subsystems communicate through typed API layers (Cpu::Link,
Cpu::Unlink, NES_PEEK_A/NES_POKE_AD macros). No shared god-object mutable
global state coupling found.

MOAD-0003: No ThreadLocal or thread-scoped identity carriers found.
Single-threaded emulation core.

MOAD-0004: No netplay or credential handling in core or fltkui. No logging
of secrets found.

MOAD-0005: No cache get+null+compute+put race patterns found. CLEAN.
This commit is contained in:
russell@unturf.com 2026-03-31 17:17:48 -04:00
parent 4d3cfc9435
commit 64dee0eb9c

Diff content is not available