Need volunteer to write a couple unit tests to prevent future regressions #42

New issue

Open

opened 2021-02-07 17:13:46 -05:00 by russellballestrini · 1 comment

russellballestrini commented

2021-02-07 17:13:46 -05:00

(Migrated from git2.unturf.com)

Created by: russellballestrini

We caught a nasty edge case in pull request #36 but we never took the time to actually codify the test cases embedded in the comments. We really need somebody to add these test cases (and any others you can thing of) into our tests located here:

current tests: https://github.com/russellballestrini/nested-lookup/blob/master/test_nested_lookup.py#L12
tips on getting pull requests approved: https://russell.ballestrini.net/tips-for-getting-pull-requests-approved/
reference: https://github.com/russellballestrini/nested-lookup/pull/36 for hints on the defect we want to guard against.

*Created by: russellballestrini* We caught a nasty edge case in pull request #36 but we never took the time to actually codify the test cases embedded in the comments. We really need somebody to add these test cases (and any others you can thing of) into our tests located here: * current tests: https://github.com/russellballestrini/nested-lookup/blob/master/test_nested_lookup.py#L12 * tips on getting pull requests approved: https://russell.ballestrini.net/tips-for-getting-pull-requests-approved/ * reference: https://github.com/russellballestrini/nested-lookup/pull/36 for hints on the defect we want to guard against.

russellballestrini commented

2021-09-10 15:47:52 -04:00

(Migrated from git2.unturf.com)

Created by: nileshfriendbuy

@russellballestrini I wanna volunteer and give this a try if you like. Thanks
Might have a few questions along the way which I will send you your way if I end up doing this

*Created by: nileshfriendbuy* - @russellballestrini I wanna volunteer and give this a try if you like. Thanks - Might have a few questions along the way which I will send you your way if I end up doing this