get_occurrence, nested_delete, nested_update is not working for keys having values 'False' or 0 #17

Closed
opened 2019-03-03 12:31:12 -05:00 by russellballestrini · 2 comments
russellballestrini commented 2019-03-03 12:31:12 -05:00 (Migrated from git2.unturf.com)

Created by: rameshrvr

Example:

>>> import nested_lookup
>>> 
>>> data = {
...             "hardware_details": {
...                 "model_name": 'MacBook Pro',
...                 "total_number_of_cores": 0,
...                 "memory": False
...             }
...         }
>>> 
>>> nested_lookup.nested_update(data, key='total_number_of_cores', value=5)
{'hardware_details': {'model_name': 'MacBook Pro', 'total_number_of_cores': 0, 'memory': False}}
>>> nested_lookup.nested_delete(data, 'memory')
{'hardware_details': {'model_name': 'MacBook Pro', 'total_number_of_cores': 0, 'memory': False}}
>>> 
>>> nested_lookup.get_occurrence_of_key(data, key='total_number_of_cores')
0

Operations are skipped since data.get(key) returned false.

*Created by: rameshrvr* Example: ``` >>> import nested_lookup >>> >>> data = { ... "hardware_details": { ... "model_name": 'MacBook Pro', ... "total_number_of_cores": 0, ... "memory": False ... } ... } >>> >>> nested_lookup.nested_update(data, key='total_number_of_cores', value=5) {'hardware_details': {'model_name': 'MacBook Pro', 'total_number_of_cores': 0, 'memory': False}} >>> nested_lookup.nested_delete(data, 'memory') {'hardware_details': {'model_name': 'MacBook Pro', 'total_number_of_cores': 0, 'memory': False}} >>> >>> nested_lookup.get_occurrence_of_key(data, key='total_number_of_cores') 0 ``` Operations are skipped since data.get(key) returned false.
russellballestrini commented 2019-03-03 12:31:30 -05:00 (Migrated from git2.unturf.com)

Created by: rameshrvr

Working on this issue. Will send a PR soon with test coverage

*Created by: rameshrvr* Working on this issue. Will send a PR soon with test coverage
russellballestrini commented 2019-03-04 08:45:21 -05:00 (Migrated from git2.unturf.com)

Created by: russellballestrini

@rameshrvr thanks!

*Created by: russellballestrini* @rameshrvr thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: python/nested-lookup#17
No description provided.