From ff8a75d42e8cdf15b2224d52dc45d193b52c700b Mon Sep 17 00:00:00 2001 From: Daniel Dourvaris Date: Wed, 14 Sep 2016 23:03:34 +0300 Subject: [PATCH] events: fix bug with _commits_as_dict which was returning only even commits --- rhodecode/events/repo.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rhodecode/events/repo.py b/rhodecode/events/repo.py index a7072c57..89b70974 100644 --- a/rhodecode/events/repo.py +++ b/rhodecode/events/repo.py @@ -57,7 +57,8 @@ def _commits_as_dict(commit_ids, repos): vcs_repo = repo.scm_instance(cache=False) try: - for commit_id in needed_commits: + # use copy of needed_commits since we modify it while iterating + for commit_id in list(needed_commits): try: cs = vcs_repo.get_changeset(commit_id) except CommitDoesNotExistError: