fix: settings, no longer create lfs dirs, and disable hgsubversion from old installations

rhodecode/apps/admin/views/settings.py

@@ -77,13 +77,16 @@ class AdminSettingsView(BaseAppView):
             raise Exception('Could not get application ui settings !')
         settings = {
             # legacy param that needs to be kept
-            'web_push_ssl': False
+            'web_push_ssl': False,
+            'extensions_hgsubversion': False
         }
         for each in ret:
             k = each.ui_key
             v = each.ui_value
+            section = each.ui_section
+
             # skip some options if they are defined
-            if k in ['push_ssl']:
+            if f"{section}_{k}" in ['web_push_ssl', 'extensions_hgsubversion']:
                 continue
 
             if k == '/':
@@ -98,7 +101,7 @@ class AdminSettingsView(BaseAppView):
             if each.ui_section in ['hooks', 'extensions']:
                 v = each.ui_active
 
-            settings[each.ui_section + '_' + k] = v
+            settings[section + '_' + k] = v
 
         return settings
 
@@ -125,8 +128,6 @@ class AdminSettingsView(BaseAppView):
         c.svn_config_path = rhodecode.ConfigGet().get_str(config_keys.config_file_path)
         defaults = self._form_defaults()
 
-        model.create_largeobjects_dirs_if_needed(defaults['paths_root_path'])
-
         data = render('rhodecode:templates/admin/settings/settings.mako',
                       self._get_template_context(c), self.request)
         html = formencode.htmlfill.render(