engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

diffs: fixed outdated files in pull-requests re-using the filediff raw_id for anchor generation.

Browse source 
In some cases when there are no longer any files this caused error since filediff wasn't present.
In addition this generated wrong ids since it used a last-defined attribute on a for loop.

Fixes #5567
This commit is contained in:
Marcin Kuzminski 2019-09-25 10:33:00 +02:00
parent 8cd4048e19
commit e9cf83badc
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
rhodecode/api/tests/test_get_repo_changeset.py
View file

@ -54,7 +54,7 @@ class TestGetRepoChangeset(object):
details=details,
)
response = api_call(self.app, params)
expected = 'commit_id must be a string value'
expected = "commit_id must be a string value got <type 'int'> instead"
assert_error(id_, expected, given=response.body)
@pytest.mark.parametrize("details", ['basic', 'extended', 'full'])
@ -137,5 +137,5 @@ class TestGetRepoChangeset(object):
details=details,
)
response = api_call(self.app, params)
expected = 'commit_id must be a string value'
expected = "commit_id must be a string value got <type 'int'> instead"
assert_error(id_, expected, given=response.body)