From e6fa851ff8f76bf92569192b09874bc0e1a7ec0b Mon Sep 17 00:00:00 2001 From: Marcin Kuzminski Date: Tue, 17 Oct 2017 20:32:23 +0200 Subject: [PATCH] db: prevent empty IN queries that generally are performance problem, and triggers sql warnings. --- rhodecode/apps/admin/views/user_groups.py | 2 +- rhodecode/apps/repository/views/repo_forks.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rhodecode/apps/admin/views/user_groups.py b/rhodecode/apps/admin/views/user_groups.py index ddfae0ca..60ef6d94 100644 --- a/rhodecode/apps/admin/views/user_groups.py +++ b/rhodecode/apps/admin/views/user_groups.py @@ -100,7 +100,7 @@ class AdminUserGroupsView(BaseAppView, DataGridAppView): auth_user_group_list = UserGroupList( UserGroup.query().all(), perm_set=['usergroup.admin']) - allowed_ids = [] + allowed_ids = [-1] for user_group in auth_user_group_list: allowed_ids.append(user_group.users_group_id) diff --git a/rhodecode/apps/repository/views/repo_forks.py b/rhodecode/apps/repository/views/repo_forks.py index 1749c585..c87d5617 100644 --- a/rhodecode/apps/repository/views/repo_forks.py +++ b/rhodecode/apps/repository/views/repo_forks.py @@ -90,7 +90,7 @@ class RepoForksView(RepoAppView, DataGridAppView): acl_check = HasRepoPermissionAny( 'repository.read', 'repository.write', 'repository.admin') repo_id = self.db_repo.repo_id - allowed_ids = [] + allowed_ids = [-1] for f in Repository.query().filter(Repository.fork_id == repo_id): if acl_check(f.repo_name, 'get forks check'): allowed_ids.append(f.repo_id)