From e146c08808eb2437c91f2aad1f43fa85cd9ddef3 Mon Sep 17 00:00:00 2001 From: Serhii Ilin Date: Fri, 26 Jan 2024 16:45:54 +0200 Subject: [PATCH] fix(app): Added proper encoding to avoid app crashes while downloading files. Fixes: RCCE-37 --- rhodecode/apps/repository/views/repo_files.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/rhodecode/apps/repository/views/repo_files.py b/rhodecode/apps/repository/views/repo_files.py index 85339392..88c690d3 100644 --- a/rhodecode/apps/repository/views/repo_files.py +++ b/rhodecode/apps/repository/views/repo_files.py @@ -808,9 +808,11 @@ class RepoFilesView(RepoAppView): safe_path = f_name.replace('"', '\\"') encoded_path = urllib.parse.quote(f_name) - return "attachment; " \ - "filename=\"{}\"; " \ - "filename*=UTF-8\'\'{}".format(safe_path, encoded_path) + headers = "attachment; " \ + "filename=\"{}\"; " \ + "filename*=UTF-8\'\'{}".format(safe_path, encoded_path) + + return headers.encode().decode('iso-8859-1', errors='replace') @LoginRequired() @HasRepoPermissionAnyDecorator(