From cc96354c0bc4ee092ac7c4fc9d4e259377bb54c8 Mon Sep 17 00:00:00 2001 From: Martin Bornhold Date: Mon, 26 Sep 2016 16:26:33 +0200 Subject: [PATCH] gists: Remove gist_type from update method in model. #4243 We do not allow to change the gist type from public to private or vice versa. Therefore there is no need to provide a ability in the model to do it. --- rhodecode/controllers/admin/gists.py | 1 - rhodecode/model/gist.py | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/rhodecode/controllers/admin/gists.py b/rhodecode/controllers/admin/gists.py index 6dee86f1..c169113b 100644 --- a/rhodecode/controllers/admin/gists.py +++ b/rhodecode/controllers/admin/gists.py @@ -298,7 +298,6 @@ class GistsController(BaseController): description=schema_data['description'], owner=c.gist.owner, gist_mapping=schema_data['nodes'], - gist_type=schema_data['gist_type'], lifetime=schema_data['lifetime'], gist_acl_level=schema_data['gist_acl_level'] ) diff --git a/rhodecode/model/gist.py b/rhodecode/model/gist.py index ab9a4d90..3cab40d1 100644 --- a/rhodecode/model/gist.py +++ b/rhodecode/model/gist.py @@ -176,8 +176,8 @@ class GistModel(BaseModel): log.error(traceback.format_exc()) raise - def update(self, gist, description, owner, gist_mapping, gist_type, - lifetime, gist_acl_level): + def update(self, gist, description, owner, gist_mapping, lifetime, + gist_acl_level): gist = self._get_gist(gist) gist_repo = gist.scm_instance() @@ -204,7 +204,6 @@ class GistModel(BaseModel): gist.gist_description = description gist.gist_expires = gist_expires gist.owner = owner - gist.gist_type = gist_type gist.acl_level = gist_acl_level self.sa.add(gist) self.sa.flush()