From b466d2779afceea3d243ac12a7989bd0ff063015 Mon Sep 17 00:00:00 2001 From: Martin Bornhold Date: Mon, 8 Aug 2016 08:24:59 +0200 Subject: [PATCH] vcs: Raise an error in case of unsupported protocol. --- rhodecode/lib/hooks_daemon.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rhodecode/lib/hooks_daemon.py b/rhodecode/lib/hooks_daemon.py index 10a62297..dd86fe3f 100644 --- a/rhodecode/lib/hooks_daemon.py +++ b/rhodecode/lib/hooks_daemon.py @@ -199,10 +199,14 @@ def prepare_callback_daemon(extras, protocol=None, use_direct_calls=False): callback_daemon = DummyHooksCallbackDaemon() extras['hooks_module'] = callback_daemon.hooks_module else: - callback_daemon = ( - Pyro4HooksCallbackDaemon() - if protocol == 'pyro4' - else HttpHooksCallbackDaemon()) + if protocol == 'pyro4': + callback_daemon = Pyro4HooksCallbackDaemon() + elif protocol == 'http': + callback_daemon = HttpHooksCallbackDaemon() + else: + log.error('Unsupported callback daemon protocol "%s"', protocol) + raise Exception('Unsupported callback daemon protocol.') + extras['hooks_uri'] = callback_daemon.hooks_uri extras['hooks_protocol'] = protocol