engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feature: fix minor bugs, fix tests

Browse source
This commit is contained in:
ievgenii.v 2025-10-30 16:46:53 +02:00
parent 1f6f5b9cc4
commit b2b9527164
2 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
rhodecode/apps/repository/tests/test_ai_code_review.py
View file

@ -86,7 +86,6 @@ class TestAiCodeReview:
assert response.status_code == 200 assert response.status_code == 200
assert run_task_mock.call_count == 1 assert run_task_mock.call_count == 1
assert len(existing_reviewers) == 1 assert ai_user.user_id in [u.user_id for u in existing_reviewers]
assert existing_reviewers[0].user_id == ai_user.user_id
assert len(success_message) == 1 assert len(success_message) == 1
assert success_message[0] == "AI code review has started. The review will be ready in about 1–3 minutes." assert success_message[0] == "AI code review has started. The review will be ready in about 1–3 minutes."

12
rhodecode/apps/repository/views/repo_pull_requests.py
View file

@ -1311,7 +1311,6 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
) )
self._try_start_ai_code_review(_, pull_request, add_existing_users=True) self._try_start_ai_code_review(_, pull_request, add_existing_users=True)
self._set_ai_pr_state_pending(pull_request)
return {"response": True, "redirect_url": redirect_url} return {"response": True, "redirect_url": redirect_url}
@ -1368,7 +1367,7 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
) )
) )
reviewers_data = [ reviewers_data.append(
( (
ai_user.user_id, ai_user.user_id,
["adds system ai user for review"], ["adds system ai user for review"],
@ -1376,7 +1375,7 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
PullRequestReviewers.ROLE_REVIEWER, PullRequestReviewers.ROLE_REVIEWER,
pull_request.reviewer_data pull_request.reviewer_data
) )
] )
PullRequestModel().update_reviewers( PullRequestModel().update_reviewers(
pull_request, reviewers_data, self._rhodecode_db_user pull_request, reviewers_data, self._rhodecode_db_user
@ -1385,6 +1384,8 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
Session().commit() Session().commit()
run_task(tasks.start_ai_code_review, pull_request.pull_request_id) run_task(tasks.start_ai_code_review, pull_request.pull_request_id)
self._set_ai_pr_state_pending(pull_request)
msg = _("AI code review has started. The review will be ready in about 1–3 minutes.") msg = _("AI code review has started. The review will be ready in about 1–3 minutes.")
h.flash(msg, category="success") h.flash(msg, category="success")
else: else:
@ -1439,10 +1440,7 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
user_id = safe_int(member_data.get("user_id", -1)) user_id = safe_int(member_data.get("user_id", -1))
if ai_user_id == user_id: if ai_user_id == user_id:
success = self._try_start_ai_code_review(_, pull_request) self._try_start_ai_code_review(_, pull_request)
if not success:
del members_[i]
break break
self._update_reviewers( self._update_reviewers(