engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pull-requests: use proper validation of pull request title to prevent from bad errors.

Browse source
This commit is contained in:
Marcin Kuzminski 2018-01-18 15:12:17 +01:00
parent d9a39181bf
commit a923fc7303
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rhodecode/apps/repository/views/repo_pull_requests.py
View file

@ -743,7 +743,7 @@ class RepoPullRequestsView(RepoAppView, DataGridAppView):
if errors.error_dict.get('revisions'):
msg = 'Revisions: %s' % errors.error_dict['revisions']
elif errors.error_dict.get('pullrequest_title'):
msg = _('Pull request requires a title with min. 3 chars')
msg = errors.error_dict.get('pullrequest_title')
else:
msg = _('Error creating pull request: {}').format(errors)
log.exception(msg)

2
rhodecode/model/forms.py
View file

@ -598,7 +598,7 @@ def PullRequestForm(localizer, repo_id):
revisions = All(#v.NotReviewedRevisions(localizer, repo_id)(),
v.UniqueList(localizer)(not_empty=True))
review_members = formencode.ForEach(ReviewerForm())
pullrequest_title = v.UnicodeString(strip=True, required=True)
pullrequest_title = v.UnicodeString(strip=True, required=True, min=3, max=255)
pullrequest_desc = v.UnicodeString(strip=True, required=False)
return _PullRequestForm