engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

auth: use single instance of auth checker to speed up execution of the permissions check by not creating new instance in each loop iteration.

Browse source
This commit is contained in:
Marcin Kuzminski 2019-12-18 12:04:40 +01:00
parent 780efd065b
commit 80708e3bd1
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
rhodecode/model/scm.py
View file

@ -126,7 +126,7 @@ class _PermCheckIterator(object):
self.obj_list = obj_list
self.obj_attr = obj_attr
self.perm_set = perm_set
self.perm_checker = perm_checker
self.perm_checker = perm_checker(*self.perm_set)
self.extra_kwargs = extra_kwargs or {}
def __len__(self):
@ -136,11 +136,10 @@ class _PermCheckIterator(object):
return '<%s (%s)>' % (self.__class__.__name__, self.__len__())
def __iter__(self):
checker = self.perm_checker(*self.perm_set)
for db_obj in self.obj_list:
# check permission at this level
name = getattr(db_obj, self.obj_attr, None)
if not checker(name, self.__class__.__name__, **self.extra_kwargs):
if not self.perm_checker(name, self.__class__.__name__, **self.extra_kwargs):
continue
yield db_obj