From 7f1d96cb47a794633dd997f9c32b6e5aa2d8637e Mon Sep 17 00:00:00 2001
From: Marcin Kuzminski <marcin@rhodecode.com>
Date: Thu, 9 Jul 2020 11:14:21 +0200
Subject: [PATCH] pull-requests: make auto generated title for pull requests
 show also source Ref type .eg. branch feature1, instead of just name of the
 branch.

---
 rhodecode/public/js/src/rhodecode/pullrequests.js | 6 ++++--
 rhodecode/templates/base/base.mako                | 2 +-
 rhodecode/templates/pullrequests/pullrequest.mako | 6 +++---
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/rhodecode/public/js/src/rhodecode/pullrequests.js b/rhodecode/public/js/src/rhodecode/pullrequests.js
index 388030a2..95c3261a 100644
--- a/rhodecode/public/js/src/rhodecode/pullrequests.js
+++ b/rhodecode/public/js/src/rhodecode/pullrequests.js
@@ -70,7 +70,7 @@ replacing '-' and '_' into spaces
 * @param limit
 * @returns {*[]}
 */
-var getTitleAndDescription = function(sourceRef, elements, limit) {
+var getTitleAndDescription = function(sourceRefType, sourceRef, elements, limit) {
   var title = '';
   var desc = '';
 
@@ -85,7 +85,9 @@ var getTitleAndDescription = function(sourceRef, elements, limit) {
   }
   else {
       // use reference name
-      title = sourceRef.replace(/-/g, ' ').replace(/_/g, ' ').capitalizeFirstLetter();
+      var normalizedRef = sourceRef.replace(/-/g, ' ').replace(/_/g, ' ').capitalizeFirstLetter()
+      var refType = sourceRefType;
+      title = 'Changes from {0}: {1}'.format(refType, normalizedRef);
   }
 
   return [title, desc]
diff --git a/rhodecode/templates/base/base.mako b/rhodecode/templates/base/base.mako
index e07b5cda..51195d7f 100644
--- a/rhodecode/templates/base/base.mako
+++ b/rhodecode/templates/base/base.mako
@@ -508,7 +508,7 @@
     ## create action
     <li>
        <a href="#create-actions" onclick="return false;" class="menulink childs">
-        <i class="tooltip icon-plus-circled" title="${_('Create')}"></i>
+        <i class="icon-plus-circled"></i>
        </a>
 
        <div class="action-menu submenu">
diff --git a/rhodecode/templates/pullrequests/pullrequest.mako b/rhodecode/templates/pullrequests/pullrequest.mako
index 656db684..fe83a674 100644
--- a/rhodecode/templates/pullrequests/pullrequest.mako
+++ b/rhodecode/templates/pullrequests/pullrequest.mako
@@ -250,9 +250,9 @@
        var added = data['stats'][0]
        var deleted = data['stats'][1]
        var commonAncestorId = data['ancestor'];
-
-       var prTitleAndDesc = getTitleAndDescription(
-           sourceRef()[1], commitElements, 5);
+       var _sourceRefType = sourceRef()[0];
+       var _sourceRefName = sourceRef()[1];
+       var prTitleAndDesc = getTitleAndDescription(_sourceRefType, _sourceRefName, commitElements, 5);
 
        var title = prTitleAndDesc[0];
        var proposedDescription = prTitleAndDesc[1];