engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

notifications: use a set initially instead of list later converted to set.

Browse source
This commit is contained in:
Marcin Kuzminski 2018-12-06 17:54:43 +01:00
parent 110ea3ebc4
commit 7857008183
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
rhodecode/model/notification.py
View file

@ -95,15 +95,14 @@ class NotificationModel(BaseModel):
log.debug('sending notifications %s to admins: %s',
notification_type, recipients_objs)
else:
recipients_objs = []
recipients_objs = set()
for u in recipients:
obj = self._get_user(u)
if obj:
recipients_objs.append(obj)
recipients_objs.add(obj)
else: # we didn't find this user, log the error and carry on
log.error('cannot notify unknown user %r', u)
recipients_objs = set(recipients_objs)
if not recipients_objs:
raise Exception('no valid recipients specified')
@ -122,7 +121,7 @@ class NotificationModel(BaseModel):
return notification
# don't send email to person who created this comment
rec_objs = set(recipients_objs).difference(set([created_by_obj]))
rec_objs = set(recipients_objs).difference({created_by_obj})
# now notify all recipients in question