From 7515b25253b23e5004eaa2f0d84ce92aa819a020 Mon Sep 17 00:00:00 2001 From: Marcin Kuzminski Date: Thu, 20 Apr 2017 14:04:15 +0200 Subject: [PATCH] comments: remove helper to render a comment object. - we always use helper renderer, and for consistency we should stick with that. It makes refactoring, and general use much harder. DB objects should have least possible logic inside. --- rhodecode/model/db.py | 4 ---- rhodecode/templates/changeset/changeset_file_comment.mako | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/rhodecode/model/db.py b/rhodecode/model/db.py index 9034a7ca..0991eaa9 100644 --- a/rhodecode/model/db.py +++ b/rhodecode/model/db.py @@ -3096,10 +3096,6 @@ class ChangesetComment(Base, BaseModel): return self.get_index_from_version( self.pull_request_version_id, versions) - def render(self, mentions=False): - from rhodecode.lib import helpers as h - return h.render(self.text, renderer=self.renderer, mentions=mentions) - def __repr__(self): if self.comment_id: return '' % self.comment_id diff --git a/rhodecode/templates/changeset/changeset_file_comment.mako b/rhodecode/templates/changeset/changeset_file_comment.mako index 9e627716..6b18cee7 100644 --- a/rhodecode/templates/changeset/changeset_file_comment.mako +++ b/rhodecode/templates/changeset/changeset_file_comment.mako @@ -158,7 +158,7 @@
- ${comment.render(mentions=True)|n} + ${h.render(comment.text, renderer=comment.renderer, mentions=True)}