pull-requests: forbid doing any changes on closed pull-requests.
- this is forbidden in the UI however we also need to prevent backend calls
This commit is contained in:
parent
7e3d628a3d
commit
6d8d44653d
3 changed files with 14 additions and 5 deletions
|
|
@ -941,6 +941,9 @@ class PullRequestModel(BaseModel):
|
|||
:param reviewer_data: list of tuples
|
||||
[(user, ['reason1', 'reason2'], mandatory_flag)]
|
||||
"""
|
||||
pull_request = self.__get_pull_request(pull_request)
|
||||
if pull_request.is_closed():
|
||||
raise ValueError('This pull request is closed')
|
||||
|
||||
reviewers = {}
|
||||
for user_id, reasons, mandatory in reviewer_data:
|
||||
|
|
@ -950,7 +953,6 @@ class PullRequestModel(BaseModel):
|
|||
'reasons': reasons, 'mandatory': mandatory}
|
||||
|
||||
reviewers_ids = set(reviewers.keys())
|
||||
pull_request = self.__get_pull_request(pull_request)
|
||||
current_reviewers = PullRequestReviewers.query()\
|
||||
.filter(PullRequestReviewers.pull_request ==
|
||||
pull_request).all()
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue