core: handle edge case requesting matched routes but with hg/svn/git or api context.

- before we error out with 500

rhodecode/apps/_base/__init__.py

@@ -22,7 +22,7 @@ import time
 import logging
 import operator
 
-from pyramid.httpexceptions import HTTPFound, HTTPForbidden
+from pyramid.httpexceptions import HTTPFound, HTTPForbidden, HTTPBadRequest
 
 from rhodecode.lib import helpers as h, diffs
 from rhodecode.lib.utils2 import StrictAttributeDict, safe_int, datetime_to_time
@@ -100,6 +100,13 @@ class BaseAppView(object):
         self.request = request
         self.context = context
         self.session = request.session
+        if not hasattr(request, 'user'):
+            # NOTE(marcink): edge case, we ended up in matched route
+            # but probably of web-app context, e.g API CALL/VCS CALL
+            if hasattr(request, 'vcs_call') or hasattr(request, 'rpc_method'):
+                log.warning('Unable to process request `%s` in this scope', request)
+                raise HTTPBadRequest()
+
         self._rhodecode_user = request.user  # auth user
         self._rhodecode_db_user = self._rhodecode_user.get_instance()
         self._maybe_needs_password_change(

rhodecode/apps/home/__init__.py

@@ -20,6 +20,23 @@
 from rhodecode.config import routing_links
 
 
+class VCSCallPredicate(object):
+    def __init__(self, val, config):
+        self.val = val
+
+    def text(self):
+        return 'vcs_call route = %s' % self.val
+
+    phash = text
+
+    def __call__(self, info, request):
+        if hasattr(request, 'vcs_call'):
+            # skip vcs calls
+            return False
+
+        return True
+
+
 def includeme(config):
 
     config.add_route(
@@ -51,3 +68,6 @@ def includeme(config):
 
     # Scan module for configuration decorators.
     config.scan('.views', ignore='.tests')
+
+    config.add_route_predicate(
+        'skip_vcs_call', VCSCallPredicate)