From 643e092c92b539345879d22496d0d13fd9e12364 Mon Sep 17 00:00:00 2001 From: Martin Bornhold Date: Thu, 6 Oct 2016 15:39:03 +0200 Subject: [PATCH] wsgi-stack: Add a more meaningful comment why we insert the error middleware. --- rhodecode/config/middleware.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rhodecode/config/middleware.py b/rhodecode/config/middleware.py index e96ed758..d8abeb52 100644 --- a/rhodecode/config/middleware.py +++ b/rhodecode/config/middleware.py @@ -192,8 +192,11 @@ def make_not_found_view(config): pylons_app = VCSMiddleware( pylons_app, settings, appenlight_client, registry=config.registry) - # Add an error handling middleware to convert errors from the old pylons - # app into a proper error page response. + # The pylons app is executed inside of the pyramid 404 exception handler. + # Exceptions which are raised inside of it are not handled by pyramid + # again. Therefore we add a middleware that invokes the error handler in + # case of an exception or error response. This way we return proper error + # HTML pages in case of an error. reraise = (settings.get('debugtoolbar.enabled', False) or rhodecode.disable_error_handler) pylons_app = PylonsErrorHandlingMiddleware(