auth: disable password change form for accounts that are not managed by RhodeCode.

- in case of external accounts such as LDAP/oAuth, password reset doesn't make sense.
- make it consisten with other disable forms for external account
- fixes #5150

rhodecode/controllers/admin/my_account.py

@@ -81,6 +81,9 @@ class MyAccountController(BaseController):
                       " crucial for entire application"), category='warning')
             return redirect(url('users'))
 
+        c.auth_user = AuthUser(
+            user_id=c.rhodecode_user.user_id, ip_addr=self.ip_addr)
+
     def _load_my_repos_data(self, watched=False):
         if watched:
             admin = False
@@ -109,8 +112,7 @@ class MyAccountController(BaseController):
         # url('my_account')
         c.active = 'profile_edit'
         self.__load_data()
-        c.perm_user = AuthUser(user_id=c.rhodecode_user.user_id,
-                               ip_addr=self.ip_addr)
+        c.perm_user = c.auth_user
         c.extern_type = c.user.extern_type
         c.extern_name = c.user.extern_name
 
@@ -182,8 +184,7 @@ class MyAccountController(BaseController):
         """
         c.active = 'profile_edit'
         self.__load_data()
-        c.perm_user = AuthUser(user_id=c.rhodecode_user.user_id,
-                               ip_addr=self.ip_addr)
+        c.perm_user = c.auth_user
         c.extern_type = c.user.extern_type
         c.extern_name = c.user.extern_name
 
@@ -199,6 +200,7 @@ class MyAccountController(BaseController):
     def my_account_password(self):
         c.active = 'password'
         self.__load_data()
+        c.extern_type = c.user.extern_type
 
         schema = user_schema.ChangePasswordSchema().bind(
             username=c.rhodecode_user.username)
@@ -206,7 +208,7 @@ class MyAccountController(BaseController):
         form = forms.Form(schema,
             buttons=(forms.buttons.save, forms.buttons.reset))
 
-        if request.method == 'POST':
+        if request.method == 'POST' and c.extern_type == 'rhodecode':
             controls = request.POST.items()
             try:
                 valid_data = form.validate(controls)
@@ -254,8 +256,7 @@ class MyAccountController(BaseController):
     def my_account_perms(self):
         c.active = 'perms'
         self.__load_data()
-        c.perm_user = AuthUser(user_id=c.rhodecode_user.user_id,
-                               ip_addr=self.ip_addr)
+        c.perm_user = c.auth_user
 
         return render('admin/my_account/my_account.html')
 

rhodecode/templates/admin/my_account/my_account_password.html

@@ -1,5 +1,13 @@
 <%namespace name="widgets" file="/widgets.html"/>
 
 <%widgets:panel title="${_('Change Your Account Password')}">
-${c.form.render() | n}
+
+% if c.extern_type != 'rhodecode':
+    <p>${_('Your user account details are managed by an external source. Details cannot be managed here.')}
+       <br/>${_('Source type')}: <strong>${c.extern_type}</strong>
+    </p>
+% else:
+    ${c.form.render() | n}
+% endif
+
 </%widgets:panel>

rhodecode/templates/admin/my_account/my_account_profile_edit.html

@@ -15,7 +15,10 @@
         <% disabled = "disabled" %>
         <div class="infoform">
           <div class="fields">
-            <p>${_('Your user account details are managed by an external source, i.e. LDAP. Details cannot be managed here.')}.</p>
+            <p>${_('Your user account details are managed by an external source. Details cannot be managed here.')}
+               <br/>${_('Source type')}: <strong>${c.extern_type}</strong>
+            </p>
+
             <div class="field">
                <div class="label">
                    <label for="username">${_('Username')}:</label>