From 43efb324b41ca071d2757404058d0290c31a7215 Mon Sep 17 00:00:00 2001 From: RhodeCode Admin Date: Wed, 16 Oct 2024 09:45:34 +0200 Subject: [PATCH] chore(code): small code improvements logging & stricter header checks --- rhodecode/lib/middleware/utils/scm_app_http.py | 3 ++- rhodecode/model/update.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/rhodecode/lib/middleware/utils/scm_app_http.py b/rhodecode/lib/middleware/utils/scm_app_http.py index 53c33e07..19be6777 100644 --- a/rhodecode/lib/middleware/utils/scm_app_http.py +++ b/rhodecode/lib/middleware/utils/scm_app_http.py @@ -167,7 +167,8 @@ def _is_request_chunked(environ): def _maybe_stream_request(environ): path = get_path_info(environ) stream = _is_request_chunked(environ) - log.debug('handling request `%s` with stream support: %s', path, stream) + req_method = environ['REQUEST_METHOD'] + log.debug('handling scm request: %s `%s` with stream support: %s', req_method, path, stream) if stream: # set stream by 256k diff --git a/rhodecode/model/update.py b/rhodecode/model/update.py index c19b3fe8..e6087fa6 100644 --- a/rhodecode/model/update.py +++ b/rhodecode/model/update.py @@ -42,7 +42,7 @@ class UpdateModel(BaseModel): ver = rhodecode.__version__ log.debug('Checking for upgrade on `%s` server', update_url) opener = urllib.request.build_opener() - opener.addheaders = [('User-agent', 'RhodeCode-SCM/%s' % ver)] + opener.addheaders = [('User-agent', f'RhodeCode-SCM/{ver.strip()}')] response = opener.open(update_url) response_data = response.read() data = json.loads(response_data)