refactoring: use form submission; removes dead code;

rhodecode/apps/admin/__init__.py

@@ -66,18 +66,6 @@ def admin_routes(config):
         renderer="rhodecode:templates/admin/security/security.mako",
     )
 
-    config.add_route(
-        name="admin_security_modify_allowed_vcs_client_versions",
-        pattern=ADMIN_PREFIX + "/security/modify/allowed_vcs_client_versions",
-    )
-    config.add_view(
-        AdminSecurityView,
-        attr="vcs_whitelisted_client_versions_edit",
-        route_name="admin_security_modify_allowed_vcs_client_versions",
-        request_method=("GET", "POST"),
-        renderer="rhodecode:templates/admin/security/edit_allowed_vcs_client_versions.mako",
-    )
-
     config.add_route(name="admin_audit_logs", pattern="/audit_logs")
     config.add_view(
         AdminAuditLogsView,

rhodecode/apps/admin/views/security.py

@@ -35,10 +35,3 @@ class AdminSecurityView(BaseAppView):
         c = self.load_default_context()
         c.active = "security"
         return self._get_template_context(c)
-
-    @LoginRequired()
-    @HasPermissionAllDecorator("hg.admin")
-    def admin_security_modify_allowed_vcs_client_versions(self):
-        c = self.load_default_context()
-        c.active = "security"
-        return self._get_template_context(c)

rhodecode/templates/admin/security/security.mako

@@ -20,19 +20,6 @@
 <%def name="main()">
 
 <div class="box">
-
-<!--    <div class="panel panel-default">-->
-<!--        <div class="panel-heading">-->
-<!--            <h3 class="panel-title">${_('Security Audit')}</h3>-->
-<!--        </div>-->
-<!--        <div class="panel-body">-->
-<!--            <h4>${_('This feature is available in RhodeCode EE edition only. Contact {sales_email} to obtain a trial license.').format(sales_email='<a href="mailto:sales@rhodecode.com">sales@rhodecode.com</a>')|n}</h4>-->
-<!--            <p>-->
-<!--                ${_('You can scan your repositories for exposed secrets, passwords, etc')}-->
-<!--            </p>-->
-<!--        </div>-->
-<!--    </div>-->
-
     <div class="panel panel-default">
         <div class="panel-heading">
             <h3 class="panel-title">${_('Allowed client versions')}</h3>
@@ -43,8 +30,6 @@
                 ${_('Some outdated client versions may have security vulnerabilities. This section have rules for whitelisting versions of clients for Git, Mercurial and SVN.')}
             </p>
     </div>
-
-
 </div>
 
 </%def>