engineering/unrhodecode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

api: pull-requests fixed logic of ancestor calculation and target ref calculation based on the web view.

Browse source
This commit is contained in:
Marcin Kuzminski 2018-07-11 17:27:30 +02:00
parent f7081008c5
commit 239874ceca
2 changed files with 31 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
rhodecode/api/tests/test_create_pull_request.py
View file

@ -93,6 +93,20 @@ class TestCreatePullRequestApi(object):
pull_request = PullRequestModel().get(pull_request_id)
assert pull_request.description == ''
@pytest.mark.backends("git", "hg")
def test_create_with_empty_title(self, backend):
data = self._prepare_data(backend)
data.pop('title')
id_, params = build_data(
self.apikey_regular, 'create_pull_request', **data)
response = api_call(self.app, params)
result = response.json
pull_request_id = result['result']['pull_request_id']
pull_request = PullRequestModel().get(pull_request_id)
data['ref'] = backend.default_branch_name
title = '{source_repo}#{ref} to {target_repo}'.format(**data)
assert pull_request.title == title
@pytest.mark.backends("git", "hg")
def test_create_with_reviewers_specified_by_names(
self, backend, no_notifications):
@ -277,6 +291,7 @@ class TestCreatePullRequestApi(object):
self.commit_ids = backend.create_master_repo(commits)
self.source = backend.create_repo(heads=[source_head])
self.target = backend.create_repo(heads=[target_head])
data = {
'source_repo': self.source.repo_name,
'target_repo': self.target.repo_name,