engineering/tpmjs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2.2k

fix(omega): return error result instead of throwing for tool failures

Browse source 
When a tool execution fails, return an error object instead of throwing.
This allows the AI model to see the error and inform the user properly,
rather than silently failing with no output.
This commit is contained in:
Ajax Davis 2026-01-25 12:38:32 +10:00
parent 4e3cb78ba4
commit 88e66d54ce
1 changed files with 35 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

56
apps/web/src/app/api/omega/conversations/[id]/messages/route.ts
View file

@ -12,7 +12,7 @@
import { Prisma, prisma } from '@tpmjs/db';
import { registryExecuteTool } from '@tpmjs/registry-execute';
import { registrySearchTool } from '@tpmjs/registry-search';
import { jsonSchema, wrapLanguageModel, type ModelMessage } from 'ai';
import { jsonSchema, type ModelMessage, wrapLanguageModel } from 'ai';
import { type NextRequest, NextResponse } from 'next/server';
import { z } from 'zod';
import { authenticateRequest } from '~/lib/api-keys/middleware';
@ -223,29 +223,43 @@ async function createDynamicTool(
execute: async (params: any) => {
console.log(`🚀 Executing ${toolMeta.packageName}/${toolMeta.name} with params:`, params);
const response = await fetch(`${EXECUTOR_URL}/execute-tool`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
packageName: toolMeta.packageName,
name: toolMeta.name,
version: toolMeta.version,
importUrl: toolMeta.importUrl,
params,
env: userEnvVars,
}),
});
try {
const response = await fetch(`${EXECUTOR_URL}/execute-tool`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
packageName: toolMeta.packageName,
name: toolMeta.name,
version: toolMeta.version,
importUrl: toolMeta.importUrl,
params,
env: userEnvVars,
}),
});
// biome-ignore lint/suspicious/noExplicitAny: API response types vary
const result = (await response.json()) as any;
// biome-ignore lint/suspicious/noExplicitAny: API response types vary
const result = (await response.json()) as any;
if (!result.success) {
console.error(`❌ Tool execution failed: ${result.error}`);
throw new Error(result.error || 'Tool execution failed');
if (!result.success) {
console.error(`❌ Tool execution failed: ${result.error}`);
// Return error as result instead of throwing so AI can see it
return {
error: true,
message: result.error || 'Tool execution failed',
toolId: toolMeta.toolId,
};
}
console.log(`✅ Tool executed in ${result.executionTimeMs}ms`);
return result.output;
} catch (error) {
console.error(`❌ Tool execution error:`, error);
return {
error: true,
message: error instanceof Error ? error.message : 'Unknown error during tool execution',
toolId: toolMeta.toolId,
};
}
console.log(`✅ Tool executed in ${result.executionTimeMs}ms`);
return result.output;
},
});
}