From d1145510e2c7f04a12a021faeaad0138339ab04c Mon Sep 17 00:00:00 2001
From: "russell@unturf.com" <russell@unturf.com>
Date: Fri, 5 Jun 2026 20:58:11 -0400
Subject: [PATCH] feat: source_format selector on new-thread create form
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The preview fix (64a15b6) honored source_format only when the textarea
already declared one — which works for editing an existing node but
not for creating a new one. Authors writing RST in the create form
saw their preview rendered as markdown, then saved into a node whose
source_format defaulted to markdown — so even the final saved page
came back wrong.

Three pieces:

- create.j2: <select> for source_format alongside the textarea.
  Default markdown; rst, html, mediawiki, latex, org, asciidoc,
  textile available. onchange syncs the chosen value into
  textarea.dataset.sourceFormat and re-runs preview, so the
  existing custom.js sendPreview picks it up unchanged.

- new_thread.py: read source_format from request.params, pass to
  set_data() so the created node's persistent source_format matches
  what the author saw in preview.

- No JS change needed — custom.js already reads
  textarea.dataset.sourceFormat.
---
 remarkbox/templates/snippets/create.j2 | 14 ++++++++++++++
 remarkbox/views/new_thread.py          |  3 ++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/remarkbox/templates/snippets/create.j2 b/remarkbox/templates/snippets/create.j2
index a4cff25..5ba1b5a 100644
--- a/remarkbox/templates/snippets/create.j2
+++ b/remarkbox/templates/snippets/create.j2
@@ -11,10 +11,24 @@
         name        = "thread_data"
         id          = "thread_data_textarea"
         class       = "common-textarea"
+        data-source-format = "markdown"
         onkeyup     = "previewAjax( 'thread_data_textarea', 'preview', show_raw=true, mathjax={{ request.mathjax }} )"
         placeholder = "What do you want to say? markdown"
         required></textarea>
 
+  <label for="source_format_select" style="display:inline-block;margin-right:0.5em">format:</label>
+  <select id="source_format_select" name="source_format"
+          onchange="document.getElementById('thread_data_textarea').dataset.sourceFormat = this.value; previewAjax('thread_data_textarea', 'preview', show_raw=true, mathjax={{ request.mathjax }})">
+    <option value="markdown" selected>markdown</option>
+    <option value="rst">reStructuredText</option>
+    <option value="html">html</option>
+    <option value="mediawiki">mediawiki</option>
+    <option value="latex">latex</option>
+    <option value="org">org</option>
+    <option value="asciidoc">asciidoc</option>
+    <option value="textile">textile</option>
+  </select>
+
   <div id='preview' name='preview' class="preview"></div>
 
 {% include 'csrf.j2' %}
diff --git a/remarkbox/views/new_thread.py b/remarkbox/views/new_thread.py
index e088250..2e0f914 100644
--- a/remarkbox/views/new_thread.py
+++ b/remarkbox/views/new_thread.py
@@ -22,6 +22,7 @@ def new_thread(request):
     thread_title = request.params.get("thread_title", "")
     thread_data = request.params.get("thread_data", "")
     anonymous_name = request.params.get("anonymous_name", "").strip()
+    source_format = request.params.get("source_format", "").strip() or None
 
     if request.spam:
         return request.spam
@@ -61,7 +62,7 @@ def new_thread(request):
         node.namespace = request.namespace
         node.ip_address = unicode(request.client_addr)
         node.title = thread_title
-        node.set_data(thread_data, dbsession=request.dbsession)
+        node.set_data(thread_data, dbsession=request.dbsession, source_format=source_format)
 
         # Handle anonymous vs authenticated user
         if user_surrogate: